Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure starknet_call calldata is not null #658

Merged
merged 2 commits into from
Jan 23, 2025
Merged

Conversation

Hyodar
Copy link
Contributor

@Hyodar Hyodar commented Jan 22, 2025

Refers to #657. Feel free to merge this if it makes sense, and not otherwise!

Copy link
Collaborator

@thiagodeev thiagodeev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Just a small request

rpc/call.go Outdated Show resolved Hide resolved
@Hyodar Hyodar requested a review from thiagodeev January 22, 2025 15:32
@thiagodeev thiagodeev merged commit a688cba into NethermindEth:main Jan 23, 2025
5 checks passed
thiagodeev added a commit that referenced this pull request Jan 30, 2025
commit f7015b7
Merge: 9199306 a688cba
Author: Thiago Ribeiro <[email protected]>
Date:   Thu Jan 30 01:26:59 2025 -0300

    Merge branch 'main' into v0.8.0

commit a688cba
Author: Franco Barpp Gomes <[email protected]>
Date:   Fri Jan 24 02:19:12 2025 +0900

    Ensure starknet_call calldata is not null (#658)

    * fix: Fix function call calldata possibly nil

    * refactor: Remove empty calldata package var

commit 46011b2
Author: Thiago Ribeiro <[email protected]>
Date:   Tue Jan 21 06:43:33 2025 -0300

    Update README.md to include typedData example (#653)

commit 45554f0
Author: Olexandr88 <[email protected]>
Date:   Mon Jan 13 16:46:46 2025 +0200

    docs: changed the link to shield stars (#652)

    Update README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants