Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated numpy aliases of builtin types #142

Closed
wants to merge 1 commit into from
Closed

Replace deprecated numpy aliases of builtin types #142

wants to merge 1 commit into from

Conversation

grahamfindlay
Copy link

Per #141

abukaj
abukaj requested changes Sep 14, 2023
View reviewed changes
Copy link
Member

@abukaj abukaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scope of code changes is much broader than declared in PR. Most of them seems to be cosmetic and code-style related. Please narrow code changes and/or explain them in the PR.

@abukaj
Copy link
Member

abukaj commented Sep 14, 2023 •
edited
Loading

Note that d816da7 fixes at least some of deprecated aliases.

@ccluri
Copy link
Collaborator

ccluri commented Dec 20, 2023

These have now been fixed with the #151 merge

@ccluri ccluri closed this Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abukaj abukaj abukaj requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grahamfindlay @abukaj @ccluri