Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pom.xml #14

Closed
wants to merge 2 commits into from
Closed

Update pom.xml #14

wants to merge 2 commits into from

Conversation

ng29
Copy link
Contributor

@ng29 ng29 commented Oct 15, 2020

No description provided.

Copy link
Contributor

@yallen011 yallen011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ng29 the pom.xml in the nexmo-spring-boot-starter-autoconfigure needs to be changed as well, which is why the build is failing. You also need to make sure you run the gradle build to make sure the build is still working. Test your changes are still working but running the send SMS sample test that is included with the project. This will require you to fork the repo and make the changes. Let me know if you have any questions or need advice on how to do any of these things. Information on running the application locally can be found in the README.

@ng29
Copy link
Contributor Author

ng29 commented Oct 19, 2020

Hi @ng29 there are other pom.xml files that need to be changed, which is why the build is failing. You also need to make sure you run the gradle build to make sure the build is still working. Test your changes are still working but running the send SMS sample test that is included with the project. This will require you to fork the repo and make the changes. Let me know if you have any questions or need advice on how to do any of these things. Information on running the application locally can be found in the README.

Hey @yallen011 , I have tried changing in all pom files and was testing that if order matters(refer my comment on issue) but it all failed again and again.
And now i am encountering bandwidth issues due to full time and side project too.
So i reckon that i would not be able to make these changes earlier so you can make this issue up for grabs .

Cheers

@yallen011
Copy link
Contributor

Ok. Thank you for your contribution.

@yallen011 yallen011 closed this Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Project to use the Vonage Server SDK and the latest Spring Boot dependency
3 participants