Merge pull request #2459 from Nexus-Mods/healthcheck-tweaks

Fixes Health Check UI bugs
Nexus-Mods · Jan 9, 2025 · 55e81e8 · 55e81e8
2 parents afe1167 + 99372cc
commit 55e81e8
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 9 deletions.
diff --git a/src/NexusMods.App.UI/Controls/Diagnostics/DiagnosticEntryView.axaml b/src/NexusMods.App.UI/Controls/Diagnostics/DiagnosticEntryView.axaml
@@ -23,12 +23,11 @@
         <DockPanel>
             <icons:UnifiedIcon x:Name="SeverityIcon" 
                                DockPanel.Dock="Left" />
-            <icons:UnifiedIcon
-                x:Name="NavigationIcon" 
+            <icons:UnifiedIcon x:Name="NavigationIcon" 
                 DockPanel.Dock="Right" 
                 Value="{x:Static icons:IconValues.ChevronRight}"/>
 
-            <StackPanel Margin="16,0">
+            <StackPanel Margin="16,0" Spacing="0">
                 <TextBlock x:Name="TitleText" 
                            Text="Name"
                            Theme="{StaticResource BodyMDNormalTheme}"

diff --git a/src/NexusMods.App.UI/Controls/Diagnostics/DiagnosticEntryView.axaml.cs b/src/NexusMods.App.UI/Controls/Diagnostics/DiagnosticEntryView.axaml.cs
@@ -31,15 +31,15 @@ private void InitializeData(IDiagnosticEntryViewModel vm)
         switch (vm.Severity)
         {
             case DiagnosticSeverity.Suggestion:
-                SeverityIcon.Value = IconValues.Help;
+                SeverityIcon.Value = IconValues.InfoFilled;
                 SeverityIcon.Classes.Add("ForegroundInfoStrong");
                 break;
             case DiagnosticSeverity.Warning:
-                SeverityIcon.Value = IconValues.Error;
+                SeverityIcon.Value = IconValues.Warning;
                 SeverityIcon.Classes.Add("ForegroundWarningStrong");
                 break;
             case DiagnosticSeverity.Critical:
-                SeverityIcon.Value = IconValues.Alert;
+                SeverityIcon.Value = IconValues.Error;
                 SeverityIcon.Classes.Add("ForegroundDangerStrong");
                 break;
             default:

diff --git a/src/NexusMods.App.UI/Pages/Diagnostics/Details/DiagnosticDetailsView.axaml b/src/NexusMods.App.UI/Pages/Diagnostics/Details/DiagnosticDetailsView.axaml
@@ -8,7 +8,7 @@
     xmlns:diagnostics="clr-namespace:NexusMods.App.UI.Pages.Diagnostics"
     xmlns:icons="clr-namespace:NexusMods.Icons;assembly=NexusMods.Icons"
     xmlns:controls="clr-namespace:NexusMods.App.UI.Controls"
-    mc:Ignorable="d" d:DesignWidth="1200" d:DesignHeight="450"
+    mc:Ignorable="d" d:DesignWidth="800" d:DesignHeight="450"
     x:Class="NexusMods.App.UI.Pages.Diagnostics.DiagnosticDetailsView">
 
     <Design.DataContext>
@@ -84,11 +84,9 @@
                 Background="#0D93C5FD"
                 BorderBrush="#6693C5FD">
 
-                <ScrollViewer Padding="0,0,24,0">
 
                     <reactiveUi:ViewModelViewHost x:Name="MarkdownRendererViewModelViewHost" />
 
-                </ScrollViewer>
             </Border>
 
         </DockPanel>

diff --git a/src/NexusMods.Icons/IconValues.cs b/src/NexusMods.Icons/IconValues.cs
@@ -148,6 +148,9 @@ public static class IconValues
     // https://pictogrammers.com/library/mdi/icon/information-outline/
     public static readonly IconValue Info = new ProjektankerIcon("mdi-information-outline");
 
+    // https://pictogrammers.com/library/mdi/icon/information/
+    public static readonly IconValue InfoFilled = new ProjektankerIcon("mdi-information");
+
 #endregion
 
 #region AV

diff --git a/src/Themes/NexusMods.Themes.NexusFluentDark/Styles/Controls/Icons/IconsStyles.axaml b/src/Themes/NexusMods.Themes.NexusFluentDark/Styles/Controls/Icons/IconsStyles.axaml
@@ -111,6 +111,8 @@
                     <icons:UnifiedIcon Classes="Package" />
                     <icons:UnifiedIcon Classes="Cardiology" />
                     <icons:UnifiedIcon Classes="LibraryOutline" />
+                    <icons:UnifiedIcon Classes="CollectionsOutline" />
+                    <icons:UnifiedIcon Classes="InfoFilled" />
                 </WrapPanel>
                 <WrapPanel>
                     <icons:UnifiedIcon Classes="Nexus" />
@@ -594,4 +596,7 @@
     <Style Selector="icons|UnifiedIcon.Swap">
         <Setter Property="Value" Value="{x:Static icons:IconValues.Swap}" />
     </Style>
+    <Style Selector="icons|UnifiedIcon.InfoFilled">
+        <Setter Property="Value" Value="{x:Static icons:IconValues.InfoFilled}" />
+    </Style>
 </Styles>