Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework installing a collection #2328

Merged
merged 22 commits into from
Dec 9, 2024
Merged

Conversation

erri120
Copy link
Member

@erri120 erri120 commented Dec 2, 2024

Part of #2254.

If you want to test this, you can't use collections that you've added previously. You must delete old collections and re-add them.

  • Reworks how collections are installed.
  • Fixes exceptions related to dates
  • Filters collections by game
  • Delete collections (doesn't remove the library items, it just removes the entities)
  • Visit collections on Nexus Mods

@erri120 erri120 self-assigned this Dec 2, 2024
@erri120 erri120 changed the title WIP: Rework installing a collection Rework installing a collection Dec 5, 2024
@erri120 erri120 requested a review from a team December 5, 2024 13:01
@erri120 erri120 mentioned this pull request Dec 5, 2024
14 tasks
Copy link
Contributor

@Al12rs Al12rs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll have a go at testing this on Monday, do you have a good collection I should test with?

There are also the schema changes here to keep track of

@erri120
Copy link
Member Author

erri120 commented Dec 5, 2024

I'll have a go at testing this on Monday, do you have a good collection I should test with?

Use the most popular Stardew Valley collections.

@Al12rs Al12rs merged commit b73ac6b into Nexus-Mods:main Dec 9, 2024
11 checks passed
@erri120 erri120 deleted the feat/2254-install branch December 9, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants