Open collection JSON file in text editor #2381
Conversation
Fixes Nexus-Mods#2383.
erri120
force-pushed
the
feat/2254-10
branch
from
073e258 to
a0e69a4
Compare
|
I have tested the PR Build and the issue with downloads is now fixed. |
| /// <summary> | ||
| /// Downloaded externally via an URL. | ||
| /// </summary> | ||
| [JsonStringEnumMemberName("Browse")] |
There was a problem hiding this comment.
Can you add a quick note that 'browse' usually indicates there's an expectation of user interaction with the URL? And that sometimes it's miscategorised by collection devs.
Might be worth noting, not everyone may always know/remember.
| @@ -138,7 +144,7 @@ public TextEditorPageViewModel( | |||
| }; | |||
|
|
|||
| Document = document; | |||
| IsReadOnly = false; | |||
| IsReadOnly = context.FileId.IsT1; | |||
There was a problem hiding this comment.
This feels like a bit of a hack; but I'm not concerned about this for now, we can leave it as-is.
Eventually down the road, mod authors will want to be able to edit their own files; and they may try doing it in the App too, so there likely will be a case where you would want non-RO LibraryFiles. But such use case is very far from now, so I'm not concerned.
|
Only misc notes. Mergeable as-is as far as I'm concerned. |
Adds a menu item to open the collection JSON file in a text editor (read-only). Allows us to better debug collection issues.
Part of #2254.
Also documents and adds some more JSON properties.