Collections improvements #16951
Merged
Collections improvements #16951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- greatly simplified the getter to improve performance - cases where a store branch leads to a null/undefined values will now return the defined fallback value correctly
- Fixed incorrect event emit for "will-install-mod" - Optimised attribute extractor registration - Fixed attribute extractors delaying mod/collection installation needlessly - Added ability to configure collection installation (e.g. install mods in parallel to download, or install on download completion of current phase)
download slots were not being freed correctly due to potentially incorrect bindings - this would become more apparent when downloading multiple collections
insomnious
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.