Skip to content

Commit

Permalink
Fix Bonsai.Editor.Tests targeting net8.0 without -windows
Browse files Browse the repository at this point in the history
Also made this NuGet warning associated with this mistake into an error.

Relates to bonsai-rx#1948 and bonsai-rx#1952
  • Loading branch information
PathogenDavid committed Aug 7, 2024
1 parent bfc8409 commit 76b9d9d
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
2 changes: 1 addition & 1 deletion Bonsai.Editor.Tests/Bonsai.Editor.Tests.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<PropertyGroup>
<IsPackable>false</IsPackable>
<GenerateDocumentationFile>false</GenerateDocumentationFile>
<TargetFrameworks>net472;net8.0</TargetFrameworks>
<TargetFrameworks>net472;net8.0-windows</TargetFrameworks>
</PropertyGroup>
<ItemGroup>
<EmbeddedResource Include="**\*.bonsai" />
Expand Down
3 changes: 3 additions & 0 deletions tooling/Common.csproj.props
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,9 @@
<!-- Ignore warnings about PackageLicenseUrl and PackageIconUrl, we still use them for MyGet support -->
<NoWarn>$(NoWarn);NU5125;NU5048</NoWarn>

<!-- Error when restore graph contains mismatched target frameworks -->
<WarningsAsErrors>$(WarningsAsErrors);NU1701</WarningsAsErrors>

<!-- Embed untracked sources in the PDB when building from CI -->
<EmbedUntrackedSources>false</EmbedUntrackedSources>
<EmbedUntrackedSources Condition="'$(ContinuousIntegrationBuild)' == 'true'">true</EmbedUntrackedSources>
Expand Down

0 comments on commit 76b9d9d

Please sign in to comment.