fix: file being used before legacy storage init

NiFeather · Oct 11, 2024 · ae37845 · ae37845
1 parent 9db780b
commit ae37845
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 8 deletions.
diff --git a/src/main/java/xyz/nifeather/morph/storage/DirectoryStorage.java b/src/main/java/xyz/nifeather/morph/storage/DirectoryStorage.java
@@ -19,7 +19,7 @@ public boolean initializeFailed()
         return initializeFailed;
     }
 
-    private boolean initializeFailed;
+    private boolean initializeFailed = false;
 
     private URI getAbsoulteURI(String path)
     {
@@ -53,6 +53,8 @@ public DirectoryStorage(String directoryBaseName)
                 this.initializeFailed = true;
             }
         }
+
+        this.initializeFailed = false;
     }
 
     public File[] getFiles(String pattern)

diff --git a/src/main/java/xyz/nifeather/morph/storage/skill/SkillsConfigurationStoreNew.java b/src/main/java/xyz/nifeather/morph/storage/skill/SkillsConfigurationStoreNew.java
@@ -52,16 +52,11 @@ private void migrateFromLegacyStorage()
         {
             logger.info("Migrating from legacy skill configuration...");
             var storage = new LegacyReadonlyConfigurationStorage();
-            var file = storage.file();
-
-            if (!file.exists())
-            {
-                logger.info("Legacy skill configuration doesn't exist, ignoring...");
-                return;
-            }
 
             storage.initializeStorage();
 
+            var file = storage.file();
+
             var storing = storage.getStoring();
             if (storing == null)
             {