Update scrollLeft in response to 'scroll' event #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the glider dots were not updated when scrolling. Also when dragging after scrolling, the scroll offset would jump back to where it was before the scrolling as soon as the drag started.
nilclass
commented
Feb 26, 2021
| @@ -83,7 +83,10 @@ | |||
| // set events | |||
| _.resize = _.init.bind(_, true) | |||
| _.event(_.ele, 'add', { | |||
| scroll: _.updateControls.bind(_) | |||
| scroll: function (event) { | |||
| _.scrollLeft = _.ele.scrollLeft | |||
There was a problem hiding this comment.
The only real change is this line. The hunks below were changed by the linter.
|
Nice catch. This looks good and makes sense to me, but I'm wondering if the assignment should just be placed in |
|
Thanks for taking a look at the changes!
To be honest, I haven't fully grasped why both |
NickPiscitelli
force-pushed
the
master
branch
from
df4a48d to
1358051
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #171
Previously the glider dots were not updated when scrolling. Also when dragging after scrolling, the scroll offset would jump back to where it was before the scrolling as soon as the drag started.
I believe the bug was introduced by the changes in #146. Oddly those changes don't seem to be part of the minified file on current master (search for
scrollLeft- it only shows up as.ele.scrollLeft), which is why the problem does not appear in the demos.