Optimizations #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Changed: BIS_fnc_selectRandom -> selectRandom * Changed: vehicle player -> objectParent * Changed: BIS_fnc_relPos -> getPos * Changed: BIS_fnc_arrayPushStack -> pushBack * Changed: BIS_fnc_dirTo -> getDir * Changed: Shopkeepers, priests, faction reps and gundealers now have less AI features. * Changed: Probably something else as well that I forgot.
Fixed all typos in the previous commit.
Applied the previous optimizations to the missions as well.
* Changed: Tanoa mission now has dynamic simulation and is binarized * Fixed: Forgot to repack overthrow_main.pbo in previous commit
Nifnat
requested changes
Jan 12, 2021
There was a problem hiding this comment.
Was looking into issue #7. Could only repro with the changes from this branch, could you replace the Tanoa mission sqm with the non binarized version but with the same changes to dynamic simulation. Will make it easier to do a comparison on changes made.
Unbinarized for debug reasons.
Nifnat
approved these changes
Jan 12, 2021
Final BIS_fnc_selectRandom removed.
|
Still want to look into #7 but it seems it might not be connected to this PR. I'm going to merge this in the meantime and then do more testing before updating the workshop version. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed: BIS_fnc_selectRandom -> selectRandom
Changed: vehicle player -> objectParent
Changed: BIS_fnc_relPos -> getPos
Changed: BIS_fnc_arrayPushStack -> pushBack
Changed: BIS_fnc_dirTo -> getDir
Changed: Shopkeepers, priests, faction reps and gundealers now have less AI features.
Changed: Added a check for arrays to OT_fnc_getOwner because some function is passing arrays to it.
Changed: Tanoa mission now has dynamic simulation and is binarized
Changed: Probably something else as well that I forgot.