Skip to content

Commit

Permalink
tast modified for notification is enabled on row_dq action_if_failed …
Browse files Browse the repository at this point in the history
…set ignore rules
  • Loading branch information
sguzel_nike committed Dec 18, 2024
1 parent 0394428 commit 702d429
Showing 1 changed file with 11 additions and 2 deletions.
13 changes: 11 additions & 2 deletions tests/core/test_expectations.py
Original file line number Diff line number Diff line change
Expand Up @@ -3228,15 +3228,15 @@ def test_se_notifications_on_rules_action_if_failed_set_ignore_sends_notificatio
"rule_type": "row_dq",
"rule": "col1_add_col3_threshold",
"column_name": "value",
"expectation": "(value) > 10",
"expectation": "value > 10",
"action_if_failed": "ignore",
"tag": "strict",
"description": "value must be greater than 10",
"enable_for_source_dq_validation": True,
"enable_for_target_dq_validation": True,
"is_active": True,
"enable_error_drop_alert": True,
"error_drop_threshold": "25",
"error_drop_threshold": "20",
},
{
"product_id": "product1",
Expand Down Expand Up @@ -3281,6 +3281,7 @@ def test_se_notifications_on_rules_action_if_failed_set_ignore_sends_notificatio
user_config.se_notifications_on_rules_action_if_failed_set_ignore: True,
user_config.se_enable_query_dq_detailed_result: True,
user_config.se_enable_agg_dq_detailed_result: True,
user_config.se_notifications_on_error_drop_threshold: 15,
}

with patch(
Expand Down Expand Up @@ -3312,6 +3313,14 @@ def get_dataset() -> DataFrame:
expected_call = (
SparkExpectationsNotify(se._context),
[
{
'rule_type': 'row_dq',
'rule': 'col1_add_col3_threshold',
'description': 'value must be greater than 10',
'tag': 'strict',
'action_if_failed': 'ignore',
'failed_row_count': 1
},
{
"rule": "value_positive_threshold",
"description": "count of value positive value must be greater than 10",
Expand Down

0 comments on commit 702d429

Please sign in to comment.