-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
107 feature enable alerts and threshold for ignore scenario #122
Merged
asingamaneni
merged 12 commits into
Nike-Inc:main
from
Suatguzl:107-feature-enable-alerts-and-threshold-for-ignore-scenario
Jan 10, 2025
Merged
107 feature enable alerts and threshold for ignore scenario #122
asingamaneni
merged 12 commits into
Nike-Inc:main
from
Suatguzl:107-feature-enable-alerts-and-threshold-for-ignore-scenario
Jan 10, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ules which has configured action_if_failed is ignore and run status failed
…as configured action_if_failed is ignore and run status failed.
- Enable notifications for rules action set to ignore if failed option is added - docs are updated explanation is added for new option.
@Suatguzl I have merged the other pr's. Can you please rebase and resolve the conflicts. |
…ction_if_failed_set_ignore parameter
@asingamaneni branch was rebased and conflicts were resolved. |
asingamaneni
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank for your contribution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This feature enhancement enables alerts for all types of data quality (DQ) issues, including 'ignore' scenarios. Previously, alerts were only sent for 'drop' scenarios in row-based DQ checks. With this update, both 'ignore' and 'drop' scenarios are covered, ensuring comprehensive monitoring of data quality issues. Threshold values remain applicable only to row-based DQ but now include both 'ignore' and 'drop' scenarios for better alerting and handling of data quality.
Related Issue
#107
Motivation and Context
The motivation behind this enhancement is to ensure comprehensive monitoring of data quality (DQ) issues by enabling alerts for both 'ignore' and 'drop' scenarios. This improvement aims to provide better oversight and handling of data quality problems, ensuring that no issues are overlooked.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: