Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

107 feature enable alerts and threshold for ignore scenario #122

Conversation

Suatguzl
Copy link
Contributor

Description

This feature enhancement enables alerts for all types of data quality (DQ) issues, including 'ignore' scenarios. Previously, alerts were only sent for 'drop' scenarios in row-based DQ checks. With this update, both 'ignore' and 'drop' scenarios are covered, ensuring comprehensive monitoring of data quality issues. Threshold values remain applicable only to row-based DQ but now include both 'ignore' and 'drop' scenarios for better alerting and handling of data quality.

Related Issue

#107

Motivation and Context

The motivation behind this enhancement is to ensure comprehensive monitoring of data quality (DQ) issues by enabling alerts for both 'ignore' and 'drop' scenarios. This improvement aims to provide better oversight and handling of data quality problems, ensuring that no issues are overlooked.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

sguzel_nike added 4 commits December 16, 2024 20:30
…ules which has configured action_if_failed is ignore and run status failed
…as configured action_if_failed is ignore and run status failed.
- Enable notifications for rules action set to ignore if failed option is added
- docs are updated explanation is added for new option.
@asingamaneni
Copy link
Collaborator

@Suatguzl I have merged the other pr's. Can you please rebase and resolve the conflicts.

@Suatguzl
Copy link
Contributor Author

@Suatguzl I have merged the other pr's. Can you please rebase and resolve the conflicts.

@asingamaneni branch was rebased and conflicts were resolved.

Copy link
Collaborator

@asingamaneni asingamaneni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank for your contribution!

@asingamaneni asingamaneni merged commit 0c265d9 into Nike-Inc:main Jan 10, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants