Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating a detailed stats table for capturing details on the execution of dq rules. #80

Merged
merged 24 commits into from
Apr 2, 2024
Merged

Conversation

vigneshwarrvenkat
Copy link
Contributor

@vigneshwarrvenkat vigneshwarrvenkat commented Mar 28, 2024

detailed stats table for capturing details on the execution of dq rules

Description

#55

Related Issue

#55

Motivation and Context

As of now, the stats table details are not sufficient to get detailed insights on the rules executed. This PR provides more details using a detailed stats table on the execution of all the rules in a relational format.

How Has This Been Tested?

The testing was done in local env with the sample data provided with this framework.

Screenshots (if appropriate):

image image image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

codecov bot commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (a725aaa) to head (58189c7).

Additional details and impacted files
@@            Coverage Diff             @@
##              main       #80    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           22        22            
  Lines         1490      1809   +319     
==========================================
+ Hits          1490      1809   +319     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@asingamaneni asingamaneni self-requested a review April 2, 2024 16:15
Copy link
Collaborator

@asingamaneni asingamaneni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

@asingamaneni asingamaneni merged commit c83762c into Nike-Inc:main Apr 2, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants