dcm2niix: add DICOM validation tests #170299
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
10.rebuild-darwin: 0
rbreslow
commented
Apr 25, 2022
| @@ -55,6 +56,42 @@ stdenv.mkDerivation rec { | |||
| "-DZLIB_IMPLEMENTATION=Cloudflare" | |||
| ]; | |||
|
|
|||
| passthru.tests = { | |||
There was a problem hiding this comment.
It's worth surfacing that the upstream project fetches the latest version of these repositories every CI run:
Comment on lines
+30
to
+29
| installPhase = '' | ||
| touch "$out" | ||
| ''; |
There was a problem hiding this comment.
This is required for Nix to think the tests are successful. Let me know if there is a more idiomatic way of writing a test case.
|
@ofborg eval |
rbreslow
force-pushed
the
dcm2niix-tests
branch
2 times, most recently
from
9e17e86 to
ba8fd02
Compare
rbreslow
force-pushed
the
dcm2niix-tests
branch
from
ba8fd02 to
c9019ec
Compare
stale
bot
added
the
2.status: stale
13 tasks
wegank
added
the
2.status: merge conflict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Add the DICOM validation tests suggested by @neurolabusc that the upstream runs as part of their Travis CI build.
Resolves d3b-center/image-deid-etl#19
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes