Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

frankenphp: add darwin support #271678

Merged
merged 3 commits into from
Dec 5, 2023
Merged

frankenphp: add darwin support #271678

merged 3 commits into from
Dec 5, 2023

Conversation

shyim
Copy link
Member

@shyim shyim commented Dec 2, 2023

Description of changes

  • Added Darwin support for Frankenphp
  • Disabled Zend Signals Support on Linux and Darwin as suggested in the docs
  • Enabled Zend max execution timers support for Linux (max_execution_time is so working)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Priorities

Add a 👍 reaction to pull requests you find important.

@shyim
Copy link
Member Author

shyim commented Dec 2, 2023

We can remove the sqlite3 substitute when dunglas/frankenphp#331 is merged and released

@drupol
Copy link
Contributor

drupol commented Dec 2, 2023

Nice! I'll pass this time as I don't know much about Darwin stuff !

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Dec 2, 2023
@drupol
Copy link
Contributor

drupol commented Dec 2, 2023 •
edited
Loading

@GrahamcOfBorg build frankenphp
@GrahamcOfBorg eval frankenphp

@drupol
Copy link
Contributor

drupol commented Dec 3, 2023

@shyim Could you please push/amend an empty commit to trigger again ofborg-eval ?

@shyim shyim force-pushed the frankenphp-darwin-support branch from 20fc552 to 21e686e Compare December 3, 2023 15:39
@shyim
Copy link
Member Author

shyim commented Dec 3, 2023 •
edited
Loading

I rebased against latest master

@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Dec 3, 2023
@ofborg ofborg bot requested a review from gaelreyrol December 3, 2023 18:04
@drupol
Copy link
Contributor

drupol commented Dec 3, 2023

@gaelreyrol Good for you?

@gaelreyrol
Copy link
Contributor

Awesome @shyim! Would you consider adding yourself as a maintainer too?

@gaelreyrol
Copy link
Contributor

Result of nixpkgs-review pr 271678 run on x86_64-linux 1

1 package built:
  • frankenphp

@delroth delroth added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Dec 5, 2023
@shyim shyim force-pushed the frankenphp-darwin-support branch from ef3a01e to 1f7636d Compare December 5, 2023 15:12
@shyim
Copy link
Member Author

shyim commented Dec 5, 2023

I added myself also as maintainer 👍

@shyim shyim force-pushed the frankenphp-darwin-support branch from 1f7636d to 64a56af Compare December 5, 2023 15:14
@shyim shyim requested a review from gaelreyrol December 5, 2023 15:18
@drupol drupol merged commit 17a63a0 into NixOS:master Dec 5, 2023
4 checks passed
@drupol
Copy link
Contributor

drupol commented Dec 5, 2023

Congrats guys, very nice :)

@shyim shyim deleted the frankenphp-darwin-support branch December 5, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaelreyrol gaelreyrol gaelreyrol approved these changes

@jtojnar jtojnar Awaiting requested review from jtojnar

@aanderse aanderse Awaiting requested review from aanderse

@drupol drupol Awaiting requested review from drupol

@etu etu Awaiting requested review from etu

@globin globin Awaiting requested review from globin

@Ma27 Ma27 Awaiting requested review from Ma27

@talyz talyz Awaiting requested review from talyz

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shyim @drupol @gaelreyrol @delroth