wireshark: 4.2.6 -> 4.4.2

[pabloaul]

Description of changes

• wireshark:
  • 4.2.6 -> 4.4.2
  • updated git patch offsets
  • lua implicit 5.2 -> explicit 5.4
  • zlib -> zlib-ng
• pyshark: add capture: Fix close_async in case the stderr task is still running KimiNewt/pyshark#670 as a patch (thank you for finding this fpletz)
• credslayer: mark as broken due to failing tests on wireshark 4.4

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[teto]

running a nixpkgs-review .python3.12-pyshark-0.6 takes > 1 hour to build and it is still building. It seems stuck in pytestCheckPhase (according to nix-output-monitor). I haven't investigated but seems like some test is stuck

[pabloaul]

Had this issue aswell with the two stuck pytestCheckPhase. The processes for each were stuck sleeping, probably a race condition.
I am not sure if this is related to my changes though since the Github Actions went through fine

[bjornfor]

I get the same hang (for 8+ hours) for nix-build -A python3Packages.pyshark on the base commit (ed96506) if I try to rebuild. However, on Hydra the build seems stable: https://hydra.nixos.org/job/nixos/trunk-combined/nixpkgs.python312Packages.pyshark.x86_64-linux

[bjornfor]

I get the same hang (for 8+ hours) for nix-build -A python3Packages.pyshark on the base commit (ed96506) if I try to rebuild.

Nope, that's wrong. (It's too early in the morning.) I can build pyshark just fine on the base branch, so the hang looks like a regression in this PR.

[bjornfor]

nix-build -A python3Packages.pyshark builds start to hang with this PR:

============================= test session starts ==============================
platform linux -- Python 3.12.5, pytest-8.3.2, pluggy-1.5.0
rootdir: /build/source
collected 73 items / 1 deselected / 72 selected                                

../tests/capture/test_capture.py .....                                   [  6%]
[...waited hours without more output...]

If we can't fix it, I think we should at least turn that hang into a quick fail before merging this PR.

[pabloaul]

Okay, this must be patch related then... I'll take a closer look soon again at the changes from Wireshark

[pabloaul]

I was unable to track down the cause for the issue. If anyone more comfortable with the code and/or capture_sync.c could take a look, it would be much appreciated...

[fpletz]

Rebased, updated to new point release and picked a patch from pyshark master to fix the capture issue.

[pabloaul]

fails some tests on a tool depending on pyshark: nix log of credslayer

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 344914

---

x86_64-linux

❌ 2 packages failed to build:

• credslayer
• credslayer.dist

✅ 26 packages built:

• compactor
• dbmonster
• haka
• hfinger
• hfinger.dist
• ostinato
• python311Packages.dissect-cobaltstrike
• python311Packages.dissect-cobaltstrike.dist
• python311Packages.manuf
• python311Packages.manuf.dist
• python311Packages.pyshark
• python311Packages.pyshark.dist
• python312Packages.dissect-cobaltstrike
• python312Packages.dissect-cobaltstrike.dist
• python312Packages.manuf
• python312Packages.manuf.dist
• python312Packages.pyshark
• python312Packages.pyshark.dist
• qtwirediff
• termshark
• tshark (wireshark-cli)
• tshark.dev (wireshark-cli.dev)
• wifite2
• wifite2.dist
• wireshark (wireshark-qt)
• wireshark.dev (wireshark-qt.dev)

[fpletz]

I would lean towards marking credslayer or maybe even pyshark itself as broken since the latter is barely maintained. Not sure what the issue is here but it's probably not our issue. We shouldn't delay bumping wireshark.

[pabloaul]

I think it would be fine to mark credslayer as broken.
pyshark seemingly still sort of works for the other projects that depend on it so I think we can leave it for now

pyshark builds, credslayer marked as broken