-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python3Packages.lark-oapi: init at 1.3.6 #355381
Open
yoctocell
wants to merge
4
commits into
NixOS:master
Choose a base branch
from
yoctocell:add-python-lark-oapi
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoctocell
changed the title
Add python lark oapi
python3Packages.lark-oapi: init at 1.3.6
Nov 12, 2024
yoctocell
force-pushed
the
add-python-lark-oapi
branch
from
November 13, 2024 11:04
65e083d
to
58b63c0
Compare
yoctocell
force-pushed
the
add-python-lark-oapi
branch
from
November 29, 2024 20:09
f70245c
to
c4a89bd
Compare
yoctocell
force-pushed
the
add-python-lark-oapi
branch
from
December 5, 2024 14:52
c4a89bd
to
8b695c3
Compare
Please apply: diff --git a/pkgs/development/python-modules/lark-oapi/default.nix b/pkgs/development/python-modules/lark-oapi/default.nix
index 99535155bad3..453962a3fbc8 100644
--- a/pkgs/development/python-modules/lark-oapi/default.nix
+++ b/pkgs/development/python-modules/lark-oapi/default.nix
@@ -4,6 +4,7 @@
fetchPypi,
requests,
requests-toolbelt,
+ setuptools,
pycryptodome,
websockets,
protobuf3,
@@ -13,13 +14,17 @@
buildPythonPackage rec {
pname = "lark-oapi";
version = "1.3.6";
- format = "setuptools";
+ pyproject = true;
src = fetchPypi {
inherit pname version;
hash = "sha256-jhis9H7z94KCJy2EM79Hy44ouDnmSIXirJ7fOCZA2G8=";
};
+ build-system = [
+ setuptools
+ ];
+
dependencies = [
requests
requests-toolbelt
@@ -29,10 +34,14 @@ buildPythonPackage rec {
httpx
];
- meta = with lib; {
+ doCheck = false; # no tests
+
+ pythonImportsCheck = [ "lark_oapi" ];
+
+ meta = {
homepage = "https://github.com/larksuite/oapi-sdk-python";
description = "Larksuite development interface SDK";
- license = licenses.mit;
- maintainers = with maintainers; [ yoctocell ];
+ license = lib.licenses.mit;
+ maintainers = with lib.maintainers; [ yoctocell ];
};
} I will leave the final review to natsukium. |
ofborg
bot
added
8.has: package (new)
This PR adds a new package
11.by: package-maintainer
This PR was created by the maintainer of the package it changes
labels
Dec 6, 2024
yoctocell
force-pushed
the
add-python-lark-oapi
branch
from
December 6, 2024 10:04
8b695c3
to
d1ae543
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
6.topic: python
8.has: package (new)
This PR adds a new package
10.rebuild-darwin: 1-10
10.rebuild-linux: 1-10
11.by: package-maintainer
This PR was created by the maintainer of the package it changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts #334067 because lark-oapi depends on protobuf <=3.20. Doing
import lark_oapi
works in the python repl.cc @aaronjheng
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.