Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.lark-oapi: init at 1.3.6 #355381

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

yoctocell
Copy link
Member

This reverts #334067 because lark-oapi depends on protobuf <=3.20. Doing import lark_oapi works in the python repl.

cc @aaronjheng

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

This reverts commit 2cc1c9e.

Needed for packaging python3Packages.lark-oapi.
This reverts commit 23d2b40.

Needed for packaging python3Packages.lark-oapi.
@nix-owners nix-owners bot requested a review from natsukium November 12, 2024 09:14
@yoctocell yoctocell changed the title Add python lark oapi python3Packages.lark-oapi: init at 1.3.6 Nov 12, 2024
@yoctocell yoctocell force-pushed the add-python-lark-oapi branch from 65e083d to 58b63c0 Compare November 13, 2024 11:04
@yoctocell yoctocell force-pushed the add-python-lark-oapi branch from f70245c to c4a89bd Compare November 29, 2024 20:09
@FliegendeWurst
Copy link
Member

FliegendeWurst commented Dec 6, 2024

Please apply:

diff --git a/pkgs/development/python-modules/lark-oapi/default.nix b/pkgs/development/python-modules/lark-oapi/default.nix
index 99535155bad3..453962a3fbc8 100644
--- a/pkgs/development/python-modules/lark-oapi/default.nix
+++ b/pkgs/development/python-modules/lark-oapi/default.nix
@@ -4,6 +4,7 @@
   fetchPypi,
   requests,
   requests-toolbelt,
+  setuptools,
   pycryptodome,
   websockets,
   protobuf3,
@@ -13,13 +14,17 @@
 buildPythonPackage rec {
   pname = "lark-oapi";
   version = "1.3.6";
-  format = "setuptools";
+  pyproject = true;
 
   src = fetchPypi {
     inherit pname version;
     hash = "sha256-jhis9H7z94KCJy2EM79Hy44ouDnmSIXirJ7fOCZA2G8=";
   };
 
+  build-system = [
+    setuptools
+  ];
+
   dependencies = [
     requests
     requests-toolbelt
@@ -29,10 +34,14 @@ buildPythonPackage rec {
     httpx
   ];
 
-  meta = with lib; {
+  doCheck = false; # no tests
+
+  pythonImportsCheck = [ "lark_oapi" ];
+
+  meta = {
     homepage = "https://github.com/larksuite/oapi-sdk-python";
     description = "Larksuite development interface SDK";
-    license = licenses.mit;
-    maintainers = with maintainers; [ yoctocell ];
+    license = lib.licenses.mit;
+    maintainers = with lib.maintainers; [ yoctocell ];
   };
 }

I will leave the final review to natsukium.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes labels Dec 6, 2024
@yoctocell yoctocell force-pushed the add-python-lark-oapi branch from 8b695c3 to d1ae543 Compare December 6, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants