Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openmw: fix build on GCC 14 #370126

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Conversation

SigmaSquadron
Copy link
Contributor

@SigmaSquadron SigmaSquadron commented Jan 2, 2025

Fixes #370061

This patch cannot be upstreamed because OpenMW does not maintain stable releases of the engine, only the in-development master branch.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review pr 370126". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • No release notes: Change is minor.
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Reported-by: Sirius902 <[email protected]>
Signed-off-by: Fernando Rodrigues <[email protected]>
@SigmaSquadron
Copy link
Contributor Author

SigmaSquadron commented Jan 2, 2025

cc @marius851000. It seems like you haven't joined the NixOS org?

cc @Sirius902 for testing.

@Sirius902
Copy link
Contributor

cc @marius851000. It seems like you haven't joined the NixOS org?

cc @Sirius902 for testing.

nix run 'github:SigmaSquadron/nixpkgs?ref=push-xqlpmvsuovsw#openmw' seems to build without issue on x86_64-linux and the game works fine, thanks!

@SigmaSquadron
Copy link
Contributor Author

SigmaSquadron commented Jan 2, 2025

portmod-rust fails due to #332957 (unrelated)

error[E0282]: type annotations needed for `Box<_>`
  --> /build/portmod-rust-2.6.2-vendor.tar.gz/time/src/format_description/parse/mod.rs:83:9
   |
83 |     let items = format_items
   |         ^^^^^
...
86 |     Ok(items.into())
   |              ---- type must be known at this point
   |
   = note: this is an inference error on crate `time` caused by an API change in Rust 1.80.0; update `time` to version `>=0.3.35` by calling `cargo update`

For more information about this error, try `rustc --explain E0282`.
error: could not compile `time` (lib) due to 1 previous error

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 370126

x86_64-linux

❌ 2 packages failed to build:
  • portmod
  • portmod.dist
✅ 1 package built:
  • openmw

@emilazy emilazy merged commit dd1853c into NixOS:master Jan 3, 2025
55 of 56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failure: openmw
3 participants