Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write TensorBoard summary to output directory. #373

Closed
Lilferrit opened this issue Sep 5, 2024 · 2 comments · Fixed by #374
Closed

Write TensorBoard summary to output directory. #373

Lilferrit opened this issue Sep 5, 2024 · 2 comments · Fixed by #374
Labels
enhancement New feature or request

Comments

@Lilferrit
Copy link
Contributor

In order to eliminate all file IO options from the Casanovo config file, we might want to have the TensorBoard SummaryWriter write directly to the directory specified with the --output_dir option. A way that this could be implemented would be to change the definition of the tb_summarywriter option to be a boolean value, and if tb_summarywriter is true write the TensorBoard summary to a subdirectory of --ouput_dir, i.e. <output_dir>/tensorboard. I have an implementation of this pushed to the branch tensorboard-io.
@Lilferrit Lilferrit added the enhancement New feature or request label Sep 5, 2024
@bittremieux
Copy link
Collaborator

Yes, nice change. Feel free to open a PR for it.

@Lilferrit
Copy link
Contributor Author

Great, I opened up a PR.

@bittremieux bittremieux linked a pull request Sep 8, 2024 that will close this issue
Tensorboard io #374
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Tensorboard io Noble-Lab/casanovo
2 participants
@bittremieux @Lilferrit