-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tensorboard io #374
Tensorboard io #374
Conversation
Alternatively we could introduce a |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #374 +/- ##
==========================================
- Coverage 94.47% 94.40% -0.07%
==========================================
Files 12 12
Lines 1067 1073 +6
==========================================
+ Hits 1008 1013 +5
- Misses 59 60 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can be merged after #372 has been completed.
No, the current solution is better. This is not a very important setting that we want to expose on the command line. |
…output setup bug fix
TensorBoard summary writer now writes to a subdirectory of
--output_dir
,<output_dir>/tensorboard
. The config optiontb_summarywriter
has been redefined to be a boolean, and if set to true the TensorBoard summary will be written to the output directory.I am marking this PR as a draft until
console-file-io
get's merged into dev, as this branch is based onconsole-file-io
and is dependent on changes introduced in that branch.