-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add shady link regex for check url with ips #260
Conversation
Hi @sairuss7 thanks for contributing 👍 Could not we use simpler regexp? Maybe with the addition of a new constant Moreover please add unit tests ( |
Developing high-quality regexps requires a great amount of rigor, so I think we should refer to an official recommendation. |
@PierreDemailly Thanks for the feedback Pierre okay I'll do it better, but for simplifying the regex, I don't really have an idea. Maybe I can do it with a tool. |
RegExp seems ok to me, but we should add new tests on the probe at least |
Co-authored-by: Thomas.G <[email protected]>
@allcontributors please add @sairuss7 for code |
I've put up a pull request to add @sairuss7! 🎉 |
resolve #260