(Do not merge) Remove migrations #810
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #810 +/- ##
==========================================
+ Coverage 65.63% 66.16% +0.52%
==========================================
Files 50 49 -1
Lines 11414 11288 -126
==========================================
- Hits 7492 7469 -23
+ Misses 3922 3819 -103 ☔ View full report in Codecov by Sentry. |
simonsso
force-pushed
the
iso_recover_testnet_rev_27
branch
from
bc22834 to
074b784
Compare
aliXsed
reviewed
Dec 19, 2023
aliXsed
reviewed
Dec 19, 2023
Comment on lines
+222
to
+224
| pallet_contracts::NoopMigration<10>, | ||
| pallet_contracts::NoopMigration<11>, | ||
| pallet_contracts::NoopMigration<12>, |
There was a problem hiding this comment.
It's likely that the following change does the same job (other than debug printing the step):
Suggested change
| pallet_contracts::NoopMigration<10>, | |
| pallet_contracts::NoopMigration<11>, | |
| pallet_contracts::NoopMigration<12>, |
There was a problem hiding this comment.
The NoopMigratoin calls will set state to 12 when done. without it there will be no change.
simonsso
commented
Dec 19, 2023
|
Released from feature branch https://github.com/NodleCode/chain/tree/recover_testnet_2_4_1_recover as https://github.com/NodleCode/chain/releases/tag/2.4.1-rc1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.