ignition: port ignition UI #6219
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The move here is to remove Ignition from the Hardhat 2 packages and build, but to a temp folder. We then move the packages into `v-next` incrementally.
This is a mechanical file move, no tweaks to support build.
This pattern allows us to provide custom inspection functions without violating the isolated declarations typescript option.
Our typescript 5.5 config includes isoldated declarations. Several mechanical type additions where added to meet this. However there was one non-trivial change. The setting of custom inspectors on Future objects was altered to meet the rules of have class with statically defined properties. The inspection methods became private and a small addition to the constructor swaps them to the `util.inspect.custom` symbol on creation.
Work around isolated declarations explicity by disabling them in mocha tests during transpilation. This will go away when we convert over to Node Test.
This is to support modern tsconfig options.
Some eslint rules are disabled for the moment. They will be dealt with in separate commits
This commit is made by apply `eslint --fix` and a few small manual changes that are unlikely to be contentious.
Ignition currently depends on the old version of Hardhat. For the moment lets build that as a project ref to keep the CI green.
This needs revisited.
We will bring these back when we have Hardhat 3 as a proper dependency.
Remove the dep on fs-extra to avoid trying to figure out how to ESM the usage.
This is to avoid asyncing every function.
Add a format property to mimic the Hardhat version. This allows us to not rely directly on the Hardhat artifact type from `core`.
We were pulling in Artifact for testing, and HRE for testing. I have left a todo to rewire HRE setup to a proper type.
We work around asyncing up the chain by directly importing the specific function.
We don't actually have access to HRE. We will bring it back later.
We are holding on pulling in the hardhat-utils version for the moment.
`cbor` is deprecated and commonjs.
The readFile changes to util changed the error returned. An assertion (flow control throw exceptions booooo) guard had to be changed to match the new error found.
This should be temporary. To run mocha with the latest tsconfig, we override the tsconfig rules via an env variable. For this to work with windows we are using `cross-env`. This should be removed when we port to Node Test Runner.
Bring all `v-next` packages into line on the latest `ethers`.
Bring all v-next packages into line on ^4.1.7 for `@types/debug`.
This is a mechanical move of the files.
Switch to the new name for the ignition-core package. Update the refs to ignition-core in the code.
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
hardhatTotal size of the bundle: List of dependencies (sorted by size) |
kanej
force-pushed
the
feat/port-ignition-ui
branch
from
f039521 to
b4418d7
Compare
Update the version to match the rest of `v-next`, and update the npm scripts to match the standard linting approach.
This is a mechanical application of `pnpm prettier --write`.
Update the version of eslint and use the shared v-next rules.
Fix up issues with the code based on the latest eslint rules in v-next.
To support ESM we are pulling in the same versions we used in ignition-core.
kanej
force-pushed
the
feat/port-ignition-ui
branch
from
b4418d7 to
98666e0
Compare
kanej
force-pushed
the
feat/port-ignition-hardhat-3
branch
from
5b743e2 to
0501043
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bring
ignition-uiintov-next.TODO