Merge pull request #135 from NordicSemiconductor/fix/missing_property…

…_type Fix: Missing prop type for pane components
NordicSemiconductor · Feb 5, 2021 · f50cc96 · f50cc96
2 parents a291439 + 60bdcdf
commit f50cc96
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 2 deletions.
diff --git a/Changelog.md b/Changelog.md
@@ -1,3 +1,8 @@
+## 4.17.3
+### Fix
+- Property `active` was missing in the TypeScript definition of the pane
+  components.
+
 ## 4.17.2
 ### Fix
 - Not defining an app reducer led to an error.

diff --git a/index.d.ts b/index.d.ts
@@ -67,6 +67,9 @@ declare module 'pc-nrfconnect-shared' {
     export const logger: winston.Logger;
 
     // App.jsx
+    export interface PaneProps {
+        active: boolean;
+    }
 
     /**
      * Props for the `App` component.
@@ -106,7 +109,7 @@ declare module 'pc-nrfconnect-shared' {
          *
          * `[['Connection Map', ConnectionMap], ['Server Setup', ServerSetup]]`
          */
-        panes: readonly (readonly [string, React.FC])[];
+        panes: readonly (readonly [string, React.FC<PaneProps>])[];
         /**
          * Describes whether the log will show automatically when the
          * application starts. Defaults to `true`.

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
     "name": "pc-nrfconnect-shared",
-    "version": "4.17.2",
+    "version": "4.17.3",
     "description": "Shared commodities for developing pc-nrfconnect-* packages",
     "repository": {
         "type": "git",