Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement PDU 24A #221

Open
wants to merge 36 commits into
base: develop
Choose a base branch
from
Open

Implement PDU 24A #221

wants to merge 36 commits into from

Conversation

bjackson312006
Copy link
Contributor

@bjackson312006 bjackson312006 commented Nov 7, 2024

Changes

  • pdu.c: Added current reading for the 4 current sensors. Set up each sensor in init_pdu. Updated pinout.
  • pdu.h: Made changes to reflect current sensing additions in pdu.c. Also updated enums to reflect what is currently on the Altium schematic.
  • monitor.c: Added a function to read the 4 currents and send a single CAN message with the readings. Called this function in vNonFunctionalDataCollection
  • fault.h: Added a fault code for current
  • cerberus_conf.h: Added a CAN ID for the current message
  • Makefile: Added INA226.c (current sensor driver)

To Do

  • Update pca9539 --> tca9539 - (Not doing this until before merge)
  • Add a current sensor read command x4 and send over CAN, corresponding YAML
  • Update pinout according to schematic.
  • Update fuse and shutdown extraction and repackaging as bools in YAML, use correct pins (note: low refresh rate)
  • Update PDU CTRL functions to correct pins.
  • Update PDU TSMS sense to correct pins
  • Update driver interaction layer as needed

Checklist

  • All commits are tagged with the ticket number
  • No merge conflicts
  • All checks passing
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes #205

@bjackson312006 bjackson312006 self-assigned this Nov 7, 2024
@bjackson312006 bjackson312006 requested a review from jr1221 November 7, 2024 16:18
@bjackson312006 bjackson312006 marked this pull request as ready for review November 10, 2024 23:55
Copy link
Contributor

@jr1221 jr1221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didnt look over actual pins yet but the overall structure is great!

Core/Src/pdu.c Outdated Show resolved Hide resolved
Copy link
Contributor

@jr1221 jr1221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, a few trivial things. This thing is going to have to sit on back burner until the board is ready. Super awesome job:)

Core/Src/pdu.c Show resolved Hide resolved
Core/Src/pdu.c Show resolved Hide resolved
Core/Src/pdu.c Outdated Show resolved Hide resolved
@jr1221
Copy link
Contributor

jr1221 commented Nov 19, 2024

NOTE: DO NOT MERGE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[IO] - Implement PDU 24A
2 participants