Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pedal to torque #254

Merged
merged 12 commits into from
Jan 19, 2025
Merged

Pedal to torque #254

merged 12 commits into from
Jan 19, 2025

Conversation

Myers-Ty
Copy link
Contributor

Changes

_New pedal to torque transfer curve as shown below. Between 0 and 20% pedal throttle the applied throttle is about halved, then afterwards it slowly approaches a 1:1 applied vs outputted throttle.

image

Test Cases

  • For the function, inputting 0% outputs 0%, inputting 100% outputs 100%, & nothing in between 0 and 100 output negative or over 100%

To Do

  • Test on car and fine tune

Closes #248

@Myers-Ty Myers-Ty self-assigned this Jan 13, 2025
Copy link
Contributor

@caiodasilva2005 caiodasilva2005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Just a few changes

Core/Src/pedals.c Show resolved Hide resolved
Core/Src/pedals.c Show resolved Hide resolved
Core/Src/pedals.c Outdated Show resolved Hide resolved
Copy link
Contributor

@caiodasilva2005 caiodasilva2005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this lgtm. @jr1221 can we get your review on this?

Core/Inc/dti.h Outdated Show resolved Hide resolved
@caiodasilva2005 caiodasilva2005 removed the request for review from jr1221 January 19, 2025 22:47
@Myers-Ty Myers-Ty merged commit 2ffb5f3 into develop Jan 19, 2025
2 checks passed
@Myers-Ty Myers-Ty deleted the pedal-to-torque branch January 19, 2025 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement alternative pedal-to-torque transfer functions
3 participants