Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for gh projects, standardize workflows #17

Merged
merged 1 commit into from
Jan 20, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 3 additions & 16 deletions .github/ISSUE_TEMPLATE/bug-form.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,33 +2,20 @@ name: Bug
description: For any issue related to a bug
title: '[Area] - Short Description'
labels: [bug]
projects: ["Northeastern-Electric-Racing/20"]
body:
- type: textarea
id: observed-behavior
attributes:
label: Observed Behavior
description: What happened?
validations:
required: true
- type: textarea
id: expected-behavior
attributes:
label: Expected Behavior
description: What should have happened?
description: What happened? What should of happened?
validations:
required: true
- type: textarea
id: steps-to-reproduce
attributes:
label: Steps to Reproduce
description: How could someone reproduce this bug?
description: How could someone reproduce this bug? Include versions of code or PCBs as applicable.
value: "1. \n2. \n3. "
validations:
required: true
- type: textarea
id: screenshots
attributes:
label: Screenshots (as needed)
description: Add screenshots of the bug if applicable
validations:
required: false
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/config.yml
Original file line number Diff line number Diff line change
@@ -1 +1 @@
blank_issues_enabled: true
blank_issues_enabled: false
64 changes: 0 additions & 64 deletions .github/ISSUE_TEMPLATE/epic.yml

This file was deleted.

26 changes: 0 additions & 26 deletions .github/ISSUE_TEMPLATE/feature-request.yml

This file was deleted.

18 changes: 0 additions & 18 deletions .github/ISSUE_TEMPLATE/other.yml

This file was deleted.

38 changes: 0 additions & 38 deletions .github/ISSUE_TEMPLATE/spike.yml

This file was deleted.

9 changes: 5 additions & 4 deletions .github/ISSUE_TEMPLATE/task.yml
Original file line number Diff line number Diff line change
@@ -1,19 +1,20 @@
name: Task
description: Create a task that a developer can complete.
name: Feature
description: Describe a feature that a developer can add.
title: '[Area] - Short Description'
projects: ["Northeastern-Electric-Racing/20"]
body:
- type: textarea
id: description
attributes:
label: Description
description: Provide a brief summary of this issue
description: Provide a brief summary of the current shortcoming or new improvement
validations:
required: true
- type: textarea
id: acceptance-criteria
attributes:
label: Acceptance Criteria
description: What are the conditions that need to be satisified to complete this task?
description: What are the test conditions that need to be satisified to complete this task?
validations:
required: true
- type: textarea
Expand Down
1 change: 0 additions & 1 deletion .github/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ It can be helpful to check the `Checks` and `Files changed` tabs.
Please reach out to your Project Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

- [ ] All commits are tagged with the ticket number
- [ ] No merge conflicts
- [ ] All checks passing
- [ ] Remove any non-applicable sections of this template
Expand Down
6 changes: 2 additions & 4 deletions .github/workflows/build-check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@ on: [push]
jobs:
run-build:
runs-on: ubuntu-latest
container:
image: ghcr.io/northeastern-electric-racing/embedded-base:main
timeout-minutes: 10
steps:
- name: Checkout code
Expand All @@ -14,7 +12,7 @@ jobs:

- name: Execute Make
run: |
if ! make; then
if ! docker compose run --rm ner-gcc-arm make -j `nproc`; then
echo "The application has failed to build."
exit 1 # This will cause the workflow to fail
fi
fi
Loading