Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rust geometry transform tool #118

Merged
merged 2 commits into from
Nov 28, 2022
Merged

Add Rust geometry transform tool #118

merged 2 commits into from
Nov 28, 2022

Conversation

Notgnoshi
Copy link
Owner

@Notgnoshi Notgnoshi commented Nov 26, 2022

  • projections
    • PCA 2D
    • PCA 3D
  • WKB I/O
  • Decide whether to keep supporting the flattened geometry format
  • How to describe composing affine transformations from the CLI?
  • How to support 3D geometries? At all?
  • Rotate
  • Scale (in x/y)
  • Skew
  • Translate

Base automatically changed from ag/refactor-rust to main November 26, 2022 19:39
@Notgnoshi Notgnoshi force-pushed the ag/transform-tool branch 2 times, most recently from 33fd513 to 94d6ccd Compare November 27, 2022 19:59
@Notgnoshi
Copy link
Owner Author

The wkt/wkb crates don't support 3D geometries. So I think that instead of combining project.py and transform to do both projections and affine transformations, I

  • keep project.py
  • remove --scale from project.py
  • do only affine transformations in transform

@Notgnoshi Notgnoshi marked this pull request as ready for review November 28, 2022 00:37
@Notgnoshi Notgnoshi linked an issue Nov 28, 2022 that may be closed by this pull request
@Notgnoshi Notgnoshi merged commit 29891e1 into main Nov 28, 2022
@Notgnoshi Notgnoshi deleted the ag/transform-tool branch November 28, 2022 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant