Skip to content

Commit

Permalink
Split #[ignored] tests into required and optional for the sake of CI
Browse files Browse the repository at this point in the history
SSH is ... not going to be pretty in CI.
  • Loading branch information
Notgnoshi committed Jul 28, 2024
1 parent a225acb commit 1c10516
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -73,4 +73,4 @@ jobs:
run: |
git fetch
cargo test --release --all-targets
cargo test --release --all-targets -- --ignored
cargo test --release --all-targets -- --ignored required
8 changes: 4 additions & 4 deletions tests/add.rs
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ use herostratus::config::{config_path, read_config, Config, RepositoryConfig};

#[test]
#[ignore = "Slow; Performs clone"]
fn clone_herostratus() {
fn required_clone_herostratus() {
let (mut cmd, temp) = common::herostratus(None);
let data_dir = temp.as_ref().unwrap().path();

Expand Down Expand Up @@ -57,7 +57,7 @@ fn clone_herostratus() {

#[test]
#[ignore = "Slow; Performs clone"]
fn clone_herostratus_branch() {
fn required_clone_herostratus_branch() {
let (mut cmd, temp) = common::herostratus(None);
let clone_dir = temp
.as_ref()
Expand Down Expand Up @@ -100,7 +100,7 @@ fn clone_herostratus_branch() {
}

#[test]
#[ignore = "Slow; Performs clone; Requires SSH"]
#[ignore = "Slow; Performs clone; Requires SSH (not available in CI)"]
fn clone_herostratus_ssh() {
let (mut cmd, temp) = common::herostratus(None);
let clone_dir = temp
Expand Down Expand Up @@ -179,7 +179,7 @@ fn add_the_same_repo_twice() {

#[test]
#[ignore = "Slow; Performs clone;"]
fn two_branches_share_one_bare_repo() {
fn required_two_branches_share_one_bare_repo() {
let (mut cmd1, temp) = common::herostratus(None);
let (mut cmd2, _) = common::herostratus(Some(temp.as_ref().unwrap().path()));

Expand Down

0 comments on commit 1c10516

Please sign in to comment.