Release Herostratus 0.1.0 #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I *heavily* rely on FZF in my development environment, and I've been
frustrated by the collisions between achievement and achievements. So
I'm renaming achievements -> rules, and leaving achievement as the
Achievement/Rule interface.
rules/
h001_fixup.rs
h002_shortest_subject_line.rs
...
achievement/
achievement.rs
process_rules.rs
rule.rs
...
I think this doesn't actually need to be a trait, that's needlessly OOPy.
My first attempt was to use inventory to register the impl Rule trait objects themselves but that failed because: 1. Rules need to be mutable 2. inventory requires the registered object be const, and Box::new() isn't a const fn 3. inventory requires the registered object by Sized So rather than registering the rules, register a factory you can use to get a new Box<dyn Rule>.
It was too much, and too opinionated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes a few internal cleanups. This PR represents the most bare minimal working "product".
Before it's usable, the following need to be done:
so that repeated
herostratus fetch-all && herostratus check-allinvocations only give new achievements