Start gitoxide migration #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My plan is to migrate from git2 to gix because gix is under active development, and has more potential to support the features I want. It's also advertised as fast, which is a project goal.
They're not that slow, with nextest, the whole test run is still under 1sec for all tests.
Note that while rev::parse could potentially be implemented in terms of rev::parse_gix, rev::walk cannot, because the iterator holds a reference to the repository. So before rev::walk can be converted, the whole call graph from main() need to switch over to gix top-down (or play more sophisticated games)
This allows more easily retrieving the commit message, author, hash, etc. details for use in tests.
This will allow testing fetching and pulling with file:// clone URLs, which results in faster tests and more flexibility than using the upstream GitHub herostratus remote in integration tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #62. The idea is that gitoxide is under active development, and is advertised as being fast, so I want to switch to it.
This is partly motivated by speed, and partly by struggling to work with git2's diff API (I also couldn't figure out gix's, so that's not a completely justified reason to migrate).
I have not yet decided if I want to build parallel implementations, or migrate the existing APIs over to gix. (Implement the git2 APIs in terms of gix with a translation shim).
So instead, this PR is focused on filling in some gaps that I noticed in another branch starting to do some migration. Of particular note is the fetch/pull tests. Switching fetch to gix revealed some shortcomings in my own understanding, the test coverage, and not necessarily a 1-1 mapping between git2 and gix's fetch APIs.