Skip to content
This repository has been archived by the owner on Sep 6, 2023. It is now read-only.

Setup volta #7

Closed
wants to merge 2 commits into from
Closed

Setup volta #7

wants to merge 2 commits into from

Conversation

NullVoxPopuli
Copy link
Owner

@NullVoxPopuli NullVoxPopuli commented May 11, 2023

This'll need thorough testing, because the volta action is meant to replace setup-node.

But:

The volta action may not have sufficient caching for workflows trying to be most optimized.

To test this action out, replace:

-- uses: NullVoxPopuli/action-setup-pnpm@v2
+- uses: NullVoxPopuli/action-setup-pnpm@NullVoxPopuli-patch-1

In neovim, do it all in one go with a : command

%s/action-setup-pnpm@\(.*\)/action-setup-pnpm@NullVoxPopuli-patch-1/g

and to revert

%s/action-setup-pnpm@\(.*\)/action-setup-pnpm@v2/g

@NullVoxPopuli NullVoxPopuli changed the title Add VOLTA_FEATURE_PNPM=1 Setup volta May 11, 2023
NullVoxPopuli added a commit to NullVoxPopuli/limber that referenced this pull request May 12, 2023
@NullVoxPopuli
Copy link
Owner Author

NullVoxPopuli commented May 12, 2023

Gonna declare using volta at all blocked by needing them to implement a cache so we don't lose the cache with the existing setup.

NullVoxPopuli added a commit to NullVoxPopuli/limber that referenced this pull request May 13, 2023
@NullVoxPopuli NullVoxPopuli deleted the NullVoxPopuli-patch-1 branch May 13, 2023 18:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant