Fixed a possible notice in error response handling. #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That is where "gwErrorCode" would be present, but "gwErrorReason" is not. In those cases, "reason" is used instead.
|
I am trying to run the PHPUnit tests locally, and the tests fail due to a notice. With this PR, they still fail, but now they fail because the exception happened in the first place, rather than due to the notice. The tests also fail, but for unrelated reasons. I don't know how to fix the failing tests, but the PHP notice is clearly wrong, hence this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That is where "gwErrorCode" would be present, but "gwErrorReason" is not. In those cases, "reason" is used instead.