Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: build HTML from src/oas.md #4254

Merged
merged 6 commits into from
Jan 15, 2025
Merged

dev: build HTML from src/oas.md #4254

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3d83a95
Build HTML from src/oas.md
ralfhandl Dec 16, 2024
a3425f2
builld into deploy-preview
ralfhandl Dec 19, 2024
0b187b6
Temp files in deploy-preview
ralfhandl Dec 23, 2024
b9c7b91
Tempfile in folder next to js folder
ralfhandl Dec 23, 2024
126d46a
Merge remote-tracking branch 'upstream/dev' into dev-build-src
ralfhandl Jan 8, 2025
8a2bb17
Preview and lint spec changes
ralfhandl Jan 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ target
atlassian-ide-plugin.xml
node_modules/
deploy/
deploy-preview/
coverage/
history
Gemfile.lock
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
"license": "Apache-2.0",
"scripts": {
"build": "bash ./scripts/md2html/build.sh",
"build-src": "bash ./scripts/md2html/build-src.sh",
"test": "c8 --100 vitest --watch=false && bash scripts/schema-test-coverage.sh",
"validate-markdown": "npx mdv src/oas.md && npx markdownlint-cli src/oas.md"
},
Expand Down
26 changes: 26 additions & 0 deletions scripts/md2html/build-src.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
#!/usr/bin/env bash

# Author: @ralfhandl

# run this script from the root of the repo

mkdir -p deploy/oas
mkdir -p deploy/js
mkdir -p deploy-preview

cp -p node_modules/respec/builds/respec-w3c.* deploy/js/

cd scripts/md2html

filename=src/oas.md
tempfile=../../deploy/oas/oas.html
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems odd to me that we're putting a tempfile under /deploy when our output is under /deploy-preview. Should we not have the tempfile there and named something obvious (eg. with tmp or temp in the name?) so that if something breaks the mess is left in the same place we were expecting output? And we can have an npm run clean-src that just deletes that directory so that it works whether the build was successful or not? (I don't care if you add clean-src in this PR or not, I'm just thinking it might be nice at some point).

echo "=== ${filename} ==="

node md2html.js --maintainers ../../EDITORS.md ../../${filename} > $tempfile
npx respec --use-local --src $tempfile --out ../../deploy-preview/oas.html
rm $tempfile

echo Built deploy-preview/oas.html
echo

rm ../../deploy/js/respec-w3c.*
Loading