[15.0][IMP] account_check_printing_report_base: Remove unnecessary dependency #782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarlosRoca13
changed the title
|
Explain a bit more the history in the commit message / PR description about initial |
CarlosRoca13
force-pushed
the
15.0-IMP-account_check_printing_report_base
branch
from
d74d1d4 to
1db6329
Compare
|
Done @pedrobaeza |
|
It seems the parameter still exists: https://github.com/OCA/account-payment/actions/runs/12864018931/job/35861689362?pr=782#step:8:352 |
report_wkhtmltopdf_param is not beeing used so remove it as dependency. In version 10, this dependency was added because the --disable-smart-shrinking option was being used. However, starting from version 12, this option is no longer necessary, so keeping the dependency is neither required nor correct. The dependency has been added to the modules that specifically use the flag, in this case, account_check_printing_report_dlt103 and account_check_printing_report_sslm102.
CarlosRoca13
force-pushed
the
15.0-IMP-account_check_printing_report_base
branch
from
1db6329 to
ef6317f
Compare
|
Yes, but not in this module, rather in |
pedrobaeza
approved these changes
Jan 20, 2025
carlosdauden
approved these changes
Jan 20, 2025
|
/ocabot merge patch |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 2da3545. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
report_wkhtmltopdf_paramis not beeing used so remove it as dependency.In version 10, this dependency was added because the
--disable-smart-shrinkingoption was being used. However, starting from version 12, this option is no longer necessary, so keeping the dependency is neither required nor correct.The dependency has been added to the modules that specifically use the flag, in this case,
account_check_printing_report_dlt103andaccount_check_printing_report_sslm102.cc @Tecnativa
ping @pedrobaeza @carlosdauden