[16.0] [MIG] website_sale_product_minimal_price #857

sbiosca-s73 · 2023-10-16T11:56:39Z

Migration module website_sale_product_minimal_price to v16.0

* [11.0][NEW] website_sale_product_minimal_price: New module * [11.0][IMP] website_sale_product_minimal_price: Order by minimal variant price (from pricelists or extra variant price) [UPD] Update website_sale_product_minimal_price.pot Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: e-commerce-11.0/e-commerce-11.0-website_sale_product_minimal_price Translate-URL: https://translation.odoo-community.org/projects/e-commerce-11-0/e-commerce-11-0-website_sale_product_minimal_price/ [UPD] README.rst

…message error

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: e-commerce-13.0/e-commerce-13.0-website_sale_product_minimal_price Translate-URL: https://translation.odoo-community.org/projects/e-commerce-13-0/e-commerce-13-0-website_sale_product_minimal_price/

… avoid the inheritance problems

Currently translated at 100.0% (2 of 2 strings) Translation: e-commerce-13.0/e-commerce-13.0-website_sale_product_minimal_price Translate-URL: https://translation.odoo-community.org/projects/e-commerce-13-0/e-commerce-13-0-website_sale_product_minimal_price/nl/

Currently translated at 100.0% (2 of 2 strings) Translation: e-commerce-13.0/e-commerce-13.0-website_sale_product_minimal_price Translate-URL: https://translation.odoo-community.org/projects/e-commerce-13-0/e-commerce-13-0-website_sale_product_minimal_price/es/

Currently translated at 100.0% (2 of 2 strings) Translation: e-commerce-13.0/e-commerce-13.0-website_sale_product_minimal_price Translate-URL: https://translation.odoo-community.org/projects/e-commerce-13-0/e-commerce-13-0-website_sale_product_minimal_price/ca/

Ensure we use a consistant currency TT28906

…s of 12.0 Forward port adapting the minimal price computing to the new way added on version 13.0. With the changes added the price takes care on the website selected pricelist and it's added the grid of price scale for each product.variant. TT24175

…list item When the product has a sales price = 0, his variants has no extra price and a pricelist depends on other pricelists to compute the prices, the algorithm takes a random variant. Doing this changes we take care all pricelists that depends on the main to compute the prices asociated to the product. This changes are forward ported and addapted to 13.0 version from this commit OCA@fe99a35#diff-d3f954ac4904966e21fd42f7b88212a43b229ad5c025afc848408a4127215ebe

Currently translated at 100.0% (6 of 6 strings) Translation: e-commerce-14.0/e-commerce-14.0-website_sale_product_minimal_price Translate-URL: https://translation.odoo-community.org/projects/e-commerce-14-0/e-commerce-14-0-website_sale_product_minimal_price/pt/

TT37015

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: e-commerce-15.0/e-commerce-15.0-website_sale_product_minimal_price Translate-URL: https://translation.odoo-community.org/projects/e-commerce-15-0/e-commerce-15-0-website_sale_product_minimal_price/

chienandalu

Tests seems to be failing

sbiosca-s73 · 2023-10-17T13:31:17Z

@chienandalu ping

chienandalu

Thanks! @sbiosca-s73

please review @stefan-tecnativa

chienandalu · 2023-10-17T15:14:36Z

website_sale_product_minimal_price/readme/CONTRIBUTORS.rst

nitpick: Add yourself to the contributors list

stefan-tecnativa · 2023-10-18T09:58:40Z

Tested on runbot, I will explain my test and the results I obtained.
I selected the "Conference Chair" product, which has an attribute "Legs" with two values: steel and aluminium. I've assigned an price_extra to the steel value of two dollars. Then i went to the shop and I correctly saw under the chairs icon the "From 35$" text, which is the correct calculation of the minimum price as the chais is 33$.
Then i went back and I changed the steel price_extra to 8$. When i go back to the shop the text is again correctly displayed but when I open the product the information is not correct. The price "label" is not correctly updated, but the final price calculation is correct.

github-actions · 2024-02-18T12:21:34Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

sbiosca-s73 · 2024-02-20T09:34:09Z

@chienandalu please apply the "no stale" label. I'm going to review the comment of @stefan-tecnativa.

Thanks!

sbiosca-s73 · 2024-02-20T12:47:39Z

@chienandalu @stefan-tecnativa I have conducted different tests to verify what Stefan mentioned. What he says is correct, but this is unrelated to the module being migrated in this PR.

Regarding the issue he mentioned, I have found a solution. Every time the price_extra of a value is changed, the website_sale module should be updated to reflect the changes on the website; otherwise, we encounter the issue Stefan mentioned.

However, as mentioned before, I don't see the module website_sale_product_minimal_price affecting the situation at any point.

Thanks!

chienandalu

Thanks @sbiosca-s73 👍

@pilarvargas-tecnativa can you review it as well?

pilarvargas-tecnativa · 2024-03-04T07:17:28Z

website_sale_product_minimal_price/readme/CONFIGURE.rst

@@ -0,0 +1,2 @@
+#. Go to *Website > Configuration > Settings > Pricing > Pricelist* and active the option *Multiple


Suggested change

#. Go to *Website > Configuration > Settings > Pricing > Pricelist* and active the option *Multiple

#. Go to *Website > Configuration > Settings > Shop - Products* and active the option *Multiple

pilarvargas-tecnativa · 2024-03-04T07:22:05Z

LGTM, please make this minor modification to the USAGE.rst file.

sbiosca-s73 · 2024-03-04T14:08:00Z

@pilarvargas-tecnativa changes done

pilarvargas-tecnativa

👍 thanks!

OCA-git-bot · 2024-03-04T14:17:23Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

pedrobaeza · 2024-03-04T14:40:18Z

/ocabot migration website_sale_product_minimal_price
/ocabot merge nobump

OCA-git-bot · 2024-03-04T14:40:37Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-857-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot · 2024-03-04T14:50:59Z

Congratulations, your PR was merged at a5c5ab0. Thanks a lot for contributing to OCA. ❤️

sergio-teruel and others added 30 commits October 16, 2023 11:10

[MIG] website_sale_product_minimal_price: Migration to v12.0

b8daa4c

[FIX] website_sale_product_minimal_price: combination does not exist …

1c932e0

…message error

website_sale_product_minimal_price 12.0.1.1.0

9ea5bda

[UPD] Update website_sale_product_minimal_price.pot

a0b7ec8

[IMP] website_sale_product_minimal_price: black, isort, prettier

fe19908

[MIG] website_sale_product_minimal_price: Migration to v13

42860fc

[IMP] website_sale_product_minimal_price: Removed the async/await for…

2102dff

… avoid the inheritance problems

website_sale_product_minimal_price 13.0.1.0.1

9f7d2ee

Added translation using Weblate (Dutch)

16897cd

Added translation using Weblate (Catalan)

32399a2

[FIX] website_sale_product_minimal_price: Fix tests

a1d21fd

Ensure we use a consistant currency TT28906

website_sale_product_minimal_price 13.0.1.0.2

d0d79a0

website_sale_product_minimal_price 13.0.1.1.0

1a402de

[IMP] website_sale_product_minimal_price: black, isort, prettier

e259c82

[MIG] website_sale_product_minimal_price: Migration to 14.0

9c1a866

Added translation using Weblate (Portuguese)

738f9e4

[MIG] website_sale_product_minimal_price: Migration to version 15.0

bee3c9e

TT37015

[UPD] Update website_sale_product_minimal_price.pot

4d8314c

[UPD] README.rst

4a6f5ac

Added translation using Weblate (French)

63c95e6

[UPD] README.rst

b90cfc4

chienandalu reviewed Oct 16, 2023

View reviewed changes

sbiosca-s73 force-pushed the 16.0-mig_website_sale_product_minimal_price branch from 30b0aa6 to ff8ead2 Compare October 17, 2023 13:21

chienandalu approved these changes Oct 17, 2023

View reviewed changes

website_sale_product_minimal_price/readme/CONTRIBUTORS.rst Outdated

Copy link

Member

chienandalu Oct 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: Add yourself to the contributors list

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Feb 18, 2024

sbiosca-s73 changed the title ~~16.0 mig website_sale_product_minimal_price~~ [16.0] [MIG] website_sale_product_minimal_price Feb 20, 2024

pedrobaeza removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Feb 22, 2024

chienandalu approved these changes Mar 1, 2024

View reviewed changes

pilarvargas-tecnativa reviewed Mar 4, 2024

View reviewed changes

[16.0][MIG]website_sale_product_minimal_price: Migration to 16.0

49b83ca

sbiosca-s73 force-pushed the 16.0-mig_website_sale_product_minimal_price branch from ff8ead2 to 49b83ca Compare March 4, 2024 13:01

pilarvargas-tecnativa approved these changes Mar 4, 2024

View reviewed changes

OCA-git-bot added approved ready to merge labels Mar 4, 2024

OCA-git-bot added this to the 16.0 milestone Mar 4, 2024

OCA-git-bot added the bot is merging ⏳ label Mar 4, 2024

OCA-git-bot mentioned this pull request Mar 4, 2024

Migration to version 16.0 #683

Open

33 tasks

OCA-git-bot merged commit f132e54 into OCA:16.0 Mar 4, 2024
7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Mar 4, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0] [MIG] website_sale_product_minimal_price #857

[16.0] [MIG] website_sale_product_minimal_price #857

sbiosca-s73 commented Oct 16, 2023

chienandalu left a comment

sbiosca-s73 commented Oct 17, 2023

chienandalu left a comment

chienandalu Oct 17, 2023

stefan-tecnativa commented Oct 18, 2023

github-actions bot commented Feb 18, 2024

sbiosca-s73 commented Feb 20, 2024

sbiosca-s73 commented Feb 20, 2024

chienandalu left a comment

pilarvargas-tecnativa Mar 4, 2024

pilarvargas-tecnativa commented Mar 4, 2024

sbiosca-s73 commented Mar 4, 2024

pilarvargas-tecnativa left a comment

OCA-git-bot commented Mar 4, 2024

pedrobaeza commented Mar 4, 2024

OCA-git-bot commented Mar 4, 2024

OCA-git-bot commented Mar 4, 2024

		@@ -0,0 +1,2 @@
		#. Go to Website > Configuration > Settings > Pricing > Pricelist and active the option *Multiple

[16.0] [MIG] website_sale_product_minimal_price #857

[16.0] [MIG] website_sale_product_minimal_price #857

Conversation

sbiosca-s73 commented Oct 16, 2023

chienandalu left a comment

Choose a reason for hiding this comment

sbiosca-s73 commented Oct 17, 2023

chienandalu left a comment

Choose a reason for hiding this comment

chienandalu Oct 17, 2023

Choose a reason for hiding this comment

stefan-tecnativa commented Oct 18, 2023

github-actions bot commented Feb 18, 2024

sbiosca-s73 commented Feb 20, 2024

sbiosca-s73 commented Feb 20, 2024

chienandalu left a comment

Choose a reason for hiding this comment

pilarvargas-tecnativa Mar 4, 2024

Choose a reason for hiding this comment

pilarvargas-tecnativa commented Mar 4, 2024

sbiosca-s73 commented Mar 4, 2024

pilarvargas-tecnativa left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Mar 4, 2024

pedrobaeza commented Mar 4, 2024

OCA-git-bot commented Mar 4, 2024

OCA-git-bot commented Mar 4, 2024