Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][ADD] helpdesk_ticket_related_tickets: New module helpdesk_ticket_related_tickets #675

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from
Open

[16.0][ADD] helpdesk_ticket_related_tickets: New module helpdesk_ticket_related_tickets #675

wants to merge 1 commit into from

Conversation

peluko00
Copy link
Contributor

@peluko00 peluko00 commented Jan 3, 2025 •
edited
Loading

This module link tickets to each other to have a more complete traceability

cc https://github.com/APSL 165295

@miquelalzanillas @lbarry-apsl @mpascuall @ppyczko @javierobcn @BernatObrador please review

@peluko00 peluko00 force-pushed the 16.0-add-helpdesk_ticket_related_tickets branch from 107de82 to 739b4db Compare January 3, 2025 15:06
BernatObrador
BernatObrador reviewed Jan 7, 2025
View reviewed changes
helpdesk_ticket_related_tickets/views/helpdesk_ticket_views.xml Outdated
<field name="arch" type="xml">
<field name="tag_ids" position="after">
<field
name="related_tickets_ids"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be a domain here to not be able to select the current ticket. ("id", "!=", id).

@ppyczko
Copy link

ppyczko commented Jan 8, 2025

I'm unable to remove a related ticket once it has been added:

imagen

BernatObrador

This comment was marked as off-topic.

Sign in to view

@peluko00 peluko00 force-pushed the 16.0-add-helpdesk_ticket_related_tickets branch 3 times, most recently from 5d544f7 to 903d0cd Compare January 8, 2025 15:20
@peluko00
Copy link
Contributor Author

peluko00 commented Jan 8, 2025

I'm unable to remove a related ticket once it has been added:

imagen

Hi @ppyczko , i'll change the logic of the module and now is working with a many2many field and a bidirectional relation.
Can you review again please @BernatObrador ?

@ppyczko
Copy link

ppyczko commented Jan 9, 2025

I'm unable to remove a related ticket once it has been added:
imagen

Hi @ppyczko , i'll change the logic of the module and now is working with a many2many field and a bidirectional relation. Can you review again please @BernatObrador ?

Looks good! The only little thing I would add is to apply the domain @BernatObrador suggested earlier to prevent adding the current ticket as a related ticket, what do you think?

related_tickets

@peluko00 peluko00 force-pushed the 16.0-add-helpdesk_ticket_related_tickets branch from 903d0cd to 7b88058 Compare January 9, 2025 07:42
@peluko00
Copy link
Contributor Author

peluko00 commented Jan 9, 2025

I'm unable to remove a related ticket once it has been added:
imagen

Hi @ppyczko , i'll change the logic of the module and now is working with a many2many field and a bidirectional relation. Can you review again please @BernatObrador ?

Looks good! The only little thing I would add is to apply the domain @BernatObrador suggested earlier to prevent adding the current ticket as a related ticket, what do you think?

related_tickets

Done, thanks!

@peluko00 peluko00 requested a review from BernatObrador January 9, 2025 07:43
ppyczko
ppyczko approved these changes Jan 9, 2025
View reviewed changes
Copy link

@ppyczko ppyczko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

mpascuall
mpascuall approved these changes Jan 9, 2025
View reviewed changes
Copy link

@mpascuall mpascuall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested in runboat

BernatObrador
BernatObrador approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@BernatObrador BernatObrador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lbarry-apsl
Copy link
Member

Hi @peluko00 ,

I have encountered this error while testing in Runboat

Captura desde 2025-01-10 10-24-51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppyczko ppyczko ppyczko approved these changes

@mpascuall mpascuall mpascuall approved these changes

@BernatObrador BernatObrador BernatObrador approved these changes

Assignees
No one assigned
Labels
approved ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@peluko00 @ppyczko @OCA-git-bot @lbarry-apsl @BernatObrador @mpascuall