Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][IMP] helpdesk_mgmt: Add open ticket in new tab #677

Closed
wants to merge 1 commit into from

Conversation

peluko00
Copy link
Contributor

@peluko00 peluko00 commented Jan 7, 2025

This PR add the possibility to access to the tickets from kanban view in another tab.

cc https://github.com/APSL 165322

@miquelalzanillas @lbarry-apsl @mpascuall @ppyczko @javierobcn @BernatObrador please review

Grabacion.de.pantalla.desde.2025-01-07.09-04-21.mp4

Copy link

@mpascuall mpascuall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, code review and tested in runboat

Copy link
Contributor

@miquelalzanillas miquelalzanillas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review LGTM

Copy link
Contributor

@BernatObrador BernatObrador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Code review and tested in runboat

@peluko00
Copy link
Contributor Author

peluko00 commented Jan 7, 2025

Sorry for ping you @pedrobaeza , can you review it? Thanks in advance

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can't change dependencies in an already merged module without strong reasons, and this one is not. Also polluting this easy one with the contributor addition is not adviced.

Do this change in your customizations, not here.

@pedrobaeza
Copy link
Member

I'm closing this as it's not going to be merged due to the already commented issues.

@pedrobaeza pedrobaeza closed this Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants