8.0 l10n br account payment mode #580
Conversation
There was a problem hiding this comment.
as for tests, there is no much logic here, so just having the module installing is probably okay. Installation depends on the l10n_br_account_banking_payment merge though. Meanwhile minor changes are required. cc @mbcosta @mileo @renatonlima
| * l10n_br_account | ||
| * l10n_br_data_base | ||
| * account_due_list_payment_mode | ||
| * account_banking_payment_export |
There was a problem hiding this comment.
account_banking_payment_export dependency is listed twice
| 'account_due_list_payment_mode', | ||
| 'account_banking_payment_export', | ||
| 'l10n_br_account_banking_payment', | ||
| ], |
There was a problem hiding this comment.
these dependencies look fine but require OCA/bank-payment and OCA/account-payment to be added in the oca_dependencies.txt file of the repo.
Also this PR depends on the merge of l10n_br_account_banking_payment in this repo. I tried to extract it with its relative commits but didn't succeed yet. I'll try it again soon.
| # You should have received a copy of the GNU Affero General Public License | ||
| # along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
| # | ||
| ############################################################################## |
There was a problem hiding this comment.
prefer shorter license headers, specially for the init.py files
| @api.constrains('bank_bic') | ||
| def check_bic_length(self): | ||
| ''' | ||
| sobrescrever constrains do core que não leva em consideração bancos |
There was a problem hiding this comment.
nao sou eu o brasileiro mas o portugues parece zoado. Nao seria melhor
"sobreescreve constraints do core..." ?
| sobrescrever constrains do core que nao leva em consideração bancos | ||
| que nao são intenacionais. | ||
| ''' | ||
| return True |
There was a problem hiding this comment.
nao sou eu o brasileiro mas o portugues parece zoado. Nao seria melhor
"sobreescreve constraints do core..." ?
| # You should have received a copy of the GNU Affero General Public License | ||
| # along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
| # | ||
| ############################################################################## |
There was a problem hiding this comment.
short style license header please
| # You should have received a copy of the GNU Affero General Public License | ||
| # along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
| # | ||
| ############################################################################## |
There was a problem hiding this comment.
short style license headers please
[FIX] pep8 [FIX] pep8 [FIX] pep8
…ancos que nao sao internacionais
mbcosta
force-pushed
the
8.0-l10n_br_account_payment_mode
branch
from
cf58b58 to
03cb284
Compare
| Brazil Account Banking - Payments Mode | ||
| ====================================== | ||
|
|
||
| This module provide an mode payment for payment orders. |
There was a problem hiding this comment.
s/provide/provides
s/an mode for payment orders/a mode for payment orders in Brazil
| # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl). | ||
|
|
||
| from . import models | ||
|
|
|
|
||
| from . import payment_mode | ||
| from . import account_invoice | ||
|
|
|
Changes done @rvalyi |
|
Error on travis seems not be related with this PR " no such option: --allow-external The command "pip install https://github.com/aricaldeira/PySPED/archive/master.zip#egg=PySPED-1.1.0 --allow-external PyXMLSec --allow-insecure PyXMLSec" failed and exited with 2 during . " |
|
Waiting merge #606 |
| # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl). | ||
|
|
||
| from . import payment_mode | ||
| from . import account_invoice |
There was a problem hiding this comment.
There is no account_invoice file
No description provided.