-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: [ADD] Migrate module account_tax_expense_include to 8.0 version #72
base: 8.0
Are you sure you want to change the base?
Conversation
a3b364f
to
1e40ff6
Compare
👍 |
When you try to add an item in an invoice you get this error: |
Looks like the conversion to the new api of "compute_all" doesn't work. |
9705626
to
b47700b
Compare
b47700b
to
b1913cf
Compare
Travis is raising this error (among others). Should I fix this? This is not in the module touched by this PR. |
@jbchouinard yes, its only one line, so its best if you fix it. Thanks |
b1913cf
to
9b4444b
Compare
I reproduced the issue noted by mmalorni, commit 3e2a52f fixes it. |
Migrate module account_tax_expense_include to 8.0 version