Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: [ADD] Migrate module account_tax_expense_include to 8.0 version #72

Open
wants to merge 4 commits into
base: 8.0
Choose a base branch
from

Conversation

joaoalf
Copy link

@joaoalf joaoalf commented Jul 27, 2015

Migrate module account_tax_expense_include to 8.0 version

@max3903 max3903 added this to the 8.0 milestone Jul 27, 2015
@joaoalf joaoalf force-pushed the 8.0-account_tax_expense_include branch from a3b364f to 1e40ff6 Compare July 28, 2015 00:44
@max3903 max3903 mentioned this pull request Jul 28, 2015
17 tasks
@max3903
Copy link
Member

max3903 commented Feb 10, 2016

👍

@mmalorni
Copy link

When you try to add an item in an invoice you get this error:
File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3142056-72-1e40ff/openerp/addons/account/account_invoice.py", line 1225, in _compute_price
taxes = self.invoice_line_tax_id.compute_all(price, self.quantity, product=self.product_id, partner=self.invoice_id.partner_id)
File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3142056-72-1e40ff/openerp/api.py", line 266, in wrapper
return new_api(self, _args, *_kwargs)
TypeError: compute_all() takes at least 4 arguments (5 given)

@mmalorni
Copy link

Looks like the conversion to the new api of "compute_all" doesn't work.

@jbchouinard jbchouinard force-pushed the 8.0-account_tax_expense_include branch from 9705626 to b47700b Compare November 23, 2016 20:21
@jbchouinard jbchouinard force-pushed the 8.0-account_tax_expense_include branch from b47700b to b1913cf Compare November 25, 2016 21:16
@jbchouinard
Copy link

************* Module l10n_ca_account_check_writing.account_voucher
l10n_ca_account_check_writing/account_voucher.py:29: [W7935(missing-import-error), ] External dependency "num2words" without ImportError. More info: https://github.com/OCA/maintainer-tools/blob/master/CONTRIBUTING.md#external-dependencies
From https://github.com/OCA/l10n-canada

Travis is raising this error (among others).

Should I fix this? This is not in the module touched by this PR.

@ghost
Copy link

ghost commented Jan 23, 2017

@jbchouinard yes, its only one line, so its best if you fix it. Thanks

@jbchouinard jbchouinard force-pushed the 8.0-account_tax_expense_include branch from b1913cf to 9b4444b Compare January 25, 2017 18:43
@jbchouinard
Copy link

I reproduced the issue noted by mmalorni, commit 3e2a52f fixes it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants