[17.0][WIP] account_factoring_receivable_balance #555

dreispt · 2024-06-07T08:24:56Z

Port from https://github.com/akretion/odoo-factoring/tree/16.0 and migration to 17.0
Related to akretion/odoo-factoring#20

…tion

ADD oca style settings FIX misc pylint UPD copier

… module

…france into 17-dr-factofrance

bealdav · 2024-06-19T13:59:06Z

Thanks for porting this module. Nice Improvements

I asked myself if this module, is not generic enough to move an account OCA repository ?

Happy to hear there

…ssing related field

[FIX] account_factoring_receivable_balance_factofrance: Constraint missing related field

bealdav · 2024-07-16T08:46:35Z

@dreispt as I proposed account_factoring_receivable_balance can move to a non localization repo and other modules could stay here . What do you think ?

But it can be done at the end of your process here

dreispt · 2024-07-16T14:26:19Z

@bealdav I agree in principle, but in the immediate term it is easier to work and refactor if they are in the same repo.
Once this is stabilized and before a merge, we can introduce those changes.

bealdav · 2024-07-17T14:14:08Z

account_factoring_receivable_balance/models/subrogation_receipt.py

+    factor_journal_id = fields.Many2one(
+        comodel_name="account.journal",
+        string="Journal",
+        domain="[('factor_type', '!=', False)," "('type', '=', 'bank')]",


@dreispt
In my experience (minor) but the journal associated to account.move used to send data to factor etablishment (invoices and credit notes) can be a misc one.
In this kind of journal you have not a lot settings, then it's less confusing to use this kind in a such context.
At least, we may consider to offer a choice.

A bank type is require to produce moves with statements data, that's not the same flow

Don't you think Daniel ?

@bealdav Good question, this was something I struggled with.
For FactoFrance we need to also report the payments on Invoices.
So I settled with using a Bank journal, allowing you to post payments on factored invoices.

@bealdav Good question, this was something I struggled with.
For FactoFrance we need to also report the payments on Invoices.
So I settled with using a Bank journal, allowing you to post payments on factored invoices.

@dreis for Factofrance I strongly recommend you look at this other module I did initially, it is used in production since 3 years in a very big company and was designed for FactoFrance: https://github.com/akretion/odoo-factoring/tree/14.0/account_factoring

You can find a demo here: https://youtu.be/N7x7MtfEF1g?si=0FbU3P1O8Iv8MgzE

bealdav · 2024-08-13T14:03:26Z

account_factoring_receivable_balance/models/res_partner.py

+
+    factor_journal_id = fields.Many2one(
+        comodel_name="account.journal",
+        domain="[('factor_type', '!=', False)]",


Required in multi-company environment

Suggested change

domain="[('factor_type', '!=', False)]",

domain="[('factor_type', '!=', False)]",

company_dependent=True,

…de to ASCII replacements

…reference instead if entry number

bealdav · 2024-09-06T07:41:09Z

account_factoring_receivable_balance_factofrance/models/account_journal.py

+    )
+    partner_identification_type = fields.Selection(
+        selection=[("1", "1 SIRET"), ("4", "4 TVA")],
+    )


@dreispt FYI in my repo I have made this settings to match with arbitrary factor keys.

https://github.com/akretion/odoo-factoring/pull/21/files#diff-2bf0078cef96b202cab38f4dcae616055927c9c3e252cc6f6b1f74a280737c02R18-R39

May be it could be generic ?

IMO that is a bit complicated.
I would go for the simpler solution, and add those additional settings as fields, only visible for tis Factor Type.
Note that the "Factor Code" is really a "Factor Contract Number", so renaming it could make sense.

It depends on your factor settings, in your case you only have one key but like any carrier dev you may have misc keys with unpredictable name or mean unshareable. If you have several factors for different companies in your ERP it becomes crazy.
But yes, it could be not so generic.

Well, the DB will have all those fields, but the user form would show only the relevant ones for the selected Factor.
Like what the shipping connectors do, as you pointed out.

A matter of taste

github-actions · 2025-01-05T12:40:24Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

dreispt force-pushed the 17-dr-factofrance branch 2 times, most recently from 03c79b7 to 75fc74b Compare June 7, 2024 08:35

dreispt mentioned this pull request Jun 7, 2024

Factoring module under the OCA akretion/odoo-factoring#20

Open

dreispt force-pushed the 17-dr-factofrance branch from b5be4a6 to 033f39a Compare June 7, 2024 11:27

bealdav and others added 26 commits June 7, 2024 12:28

[ADD] 15.0 module base_factoring

cda54e5

[ADD] 15.0 module account_factoring_receivable_balance

6c2ac59

[ADD] 15.0 module account_factoring_receivable_balance_bpce

5f68206

ADD translations

f971a03

FIX acc_facto_balance: remove useless code

1076ff5

FIX acc_facto_balance: add check on _get_bank_journal()

ed63212

IMP acc_facto: remove server action, filter with target date, transla…

30f2d8d

…tion

FIX acc_facto_balance: remove subrog_id from domain

6e5f8a3

FIX acc_facto_balance: link move lines with m2m instead of o2m

6828935

IMP acc_facto: view, compute balance while calculating

0170694

IMP acc_facto: set balance in vals instead of self.balance

1240f49

UPD with precommit

06f64b3

ADD oca style settings FIX misc pylint UPD copier

FIX acc_facto_balance: field collision with acc_paym_order

2f18f2b

FIX acc_facto_balance: _get_company()

73f6cfb

FIX facto_bpce: error field on move

0be85a2

FIX facto_bpce: env.company, instead of env.user.company_id

575638c

FIX facto_receiv: typo

3638180

[REF] pre-commit: copier update

9422c27

[IMP] account_factoring_receivable_balance: pre-commit execution

e47edfb

[MIG] account_factoring_receivable_balance: Migration to 17.0

948e2c4

[IMP] account_factoring_receivable_balance_bpce: pre-commit execution

016f7c2

[MIG] account_factoring_receivable_balance_bpce: Migration to 17.0

019335a

[REF] account_factoring_receivable_balance: merge base_factor in this…

c2966d0

… module

[REF] account_factoring_receivable_balance_bpce: removed base_factoring

a4fe03e

[FIX] account_factoring_receivable_balance: pre-commit fixes

ca480ae

[FIX] account_factoring_receivable_balance_bpce: pre-commit fixes

0929bf6

Murtaza-OSI and others added 5 commits June 14, 2024 15:47

[IMP] IMP code.

f233df5

[IMP] Invoice Due Date.

a25c3b8

[FIX] account_factoring_receivable_balance_factofrance

8381d65

Merge branch '17-dr-factofrance' of git+ssh://github.com/ursais/l10n-…

7625047

…france into 17-dr-factofrance

[FIX] account_factoring_receivable_balance

b7dfa06

Murtaza-OSI added 2 commits June 25, 2024 17:43

[IMP] Imporved the code.

6d444d2

[FIX] Pre-commit.

bfebb9f

dreispt force-pushed the 17-dr-factofrance branch 2 times, most recently from 08633bd to bd299ff Compare July 4, 2024 20:31

[FIX] account_factoring_receivable_balance_factofrance

86dd4e4

dreispt force-pushed the 17-dr-factofrance branch from bd299ff to 86dd4e4 Compare July 4, 2024 20:59

RLeeOSI and others added 4 commits July 9, 2024 20:32

[FIX] account_factoring_receivable_balance_factofrance: Constraint mi…

9830078

…ssing related field

Merge pull request #1 from ursais/rl-fix-factofrance

df18a1c

[FIX] account_factoring_receivable_balance_factofrance: Constraint missing related field

[WIP] account_factoring_receivable_balance

ada93fa

[WIP] account_factoring_receivable_balance_factofrance

210df92

dreispt added 2 commits July 16, 2024 14:51

[FIX] account_factoring_receivable_balance: remove item_ids

24a95cb

[FIX] account_factoring_receivable_balance_factofrance: remove item_ids

82e5000

bealdav reviewed Jul 17, 2024

View reviewed changes

dreispt added 3 commits July 30, 2024 09:36

[WIP] account_factoring_receivable_balance_factofrance

422b155

[WIP] account_factoring_receivable_balance

549f4b3

[WIP] account_factoring_receivable_balance_factofrance

9f653e3

bealdav reviewed Aug 13, 2024

View reviewed changes

dreispt added 2 commits August 28, 2024 09:57

[FIX] account_factoring_receivable_balance_factofrance: convert unico…

c9fec06

…de to ASCII replacements

[FIX] account_factoring_receivable_balance_factofrance: payments use …

a0ab5df

…reference instead if entry number

bealdav reviewed Sep 6, 2024

View reviewed changes

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jan 5, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[17.0][WIP] account_factoring_receivable_balance #555

[17.0][WIP] account_factoring_receivable_balance #555

dreispt commented Jun 7, 2024 •

edited

Loading

bealdav commented Jun 19, 2024

bealdav commented Jul 16, 2024 •

edited

Loading

dreispt commented Jul 16, 2024

bealdav Jul 17, 2024 •

edited

Loading

dreispt Jul 30, 2024

rvalyi Sep 6, 2024 •

edited

Loading

bealdav Aug 13, 2024

bealdav Sep 6, 2024 •

edited

Loading

dreispt Sep 6, 2024

bealdav Sep 6, 2024

dreispt Sep 6, 2024

bealdav Sep 6, 2024

github-actions bot commented Jan 5, 2025

	domain="[('factor_type', '!=', False)]",
	domain="[('factor_type', '!=', False)]",
	company_dependent=True,

[17.0][WIP] account_factoring_receivable_balance #555

Are you sure you want to change the base?

[17.0][WIP] account_factoring_receivable_balance #555

Conversation

dreispt commented Jun 7, 2024 • edited Loading

bealdav commented Jun 19, 2024

bealdav commented Jul 16, 2024 • edited Loading

dreispt commented Jul 16, 2024

bealdav Jul 17, 2024 • edited Loading

Choose a reason for hiding this comment

dreispt Jul 30, 2024

Choose a reason for hiding this comment

rvalyi Sep 6, 2024 • edited Loading

Choose a reason for hiding this comment

bealdav Aug 13, 2024

Choose a reason for hiding this comment

bealdav Sep 6, 2024 • edited Loading

Choose a reason for hiding this comment

dreispt Sep 6, 2024

Choose a reason for hiding this comment

bealdav Sep 6, 2024

Choose a reason for hiding this comment

dreispt Sep 6, 2024

Choose a reason for hiding this comment

bealdav Sep 6, 2024

Choose a reason for hiding this comment

github-actions bot commented Jan 5, 2025

dreispt commented Jun 7, 2024 •

edited

Loading

bealdav commented Jul 16, 2024 •

edited

Loading

bealdav Jul 17, 2024 •

edited

Loading

rvalyi Sep 6, 2024 •

edited

Loading

bealdav Sep 6, 2024 •

edited

Loading