18.0 mig l10n fr siret lookup

[fredericgrall]

No description provided.

[sbidoul]

/ocabot migration l10n_fr_siret_lookup

[OCA-git-bot]

@sbidoul The migration issue commenter process could not start, because of exception Command '['git', 'fetch', '--quiet', '--force', '--prune', 'https://github.com/OCA/l10n-france', 'refs/heads/:refs/heads/']' returned non-zero exit status 128..

[sbidoul]

/ocabot migration l10n_fr_siret_lookup

[alexis-via]

Thanks for your work on this. I propose minor updates to your PR here: apikcloud#1

[remi-filament]

Thanks @fredericgrall
It works fine.

Could you please run pre-commit locally to fix reported issue, rebase on v18.0 and force push your changes ?
Best Regards,

[fredericgrall]

@remi-filament it's done

[remi-filament]

Thanks @fredericgrall however you merged branch 18.0 on your own branch instead of rebasing so that you add extra commit in history.
Also pre-commit is still failing.
You also need to clean-up history as per https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate

If you are not familiar with these instructions, let me try to guide you step by step :

1. Before changing history, backup your updates in a backup branch : git checkout 18.0-mig-l10n_fr_siret_lookup && git branch pr-579-bak
2. Go back to your last commit : git reset --hard 8535c72c58694270352e012c897c7debd4c0089e
3. Clean-up existing history : git rebase -i origin/18.0 (assuming origin is OCA repo and your local copy is up to date) then fixup all commits starting with [UPD] and also squash your 2 last commits in one

You should have something like :

pick 4504efd9 Rename module to l10n_fr_siret_lookup
f d201ae83 [UPD] Update l10n_fr_siret_lookup.pot
f 591fb801 [UPD] README.rst
pick b5579df5 Translated using Weblate (French)
pick b87aaba7 [FIX] l10n_fr_siret_lookup: zip is now given as int by the API
f 22f68391 l10n_fr_siret_lookup 14.0.1.1.0
f 822b8e9c Translated using Weblate (French)
pick 35ec202c [MIG] l10n_fr_siret_lookup to v16
f 56a491bb [UPD] Update l10n_fr_siret_lookup.pot
f 21802629 [UPD] README.rst
f afd63a46 Update translation files
pick 8d9c45f2 Added translation using Weblate (Spanish)
f 240a339f [UPD] README.rst
f b542795f Translated using Weblate (Spanish)
pick ce5fdccb [IMP] l10n_fr_siret_lookup: pre-commit auto fixes
pick 41ecc6ae [MIG] l10n_fr_siret_lookup: Migration to 18.0
f 8535c72c [MIG] l10n_fr_siret_lookup: Migration to 18.0

4. Cherry pick commits from Alexis : git cherry-pick 262746088d87ab7592fb04618026b179ae300cf5 4e4bbb18c89a70dcdc9ca15f3a3936363715d067
5. Run pre-commit : pre-commit run --file l10n_fr_siret_lookup/
6. Add pre-commit result in last commit : git commit l10n_fr_siret_lookup/README.rst l10n_fr_siret_lookup/static/description/index.html --amend
7. Check that you get the same result as your backup branch : git diff 18.0-mig-l10n_fr_siret_lookup pr-579-bak (you should though have a difference on the latest README.rst and index.html files modified by pre-commit)
8. Check your module is properly working and force push your branch