Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] pos_cash_move_reason: Migration to 17.0 #1230

Closed

Conversation

traitrantrobz
Copy link

@traitrantrobz traitrantrobz commented Aug 2, 2024

Depends on: #1232

adrienpeiffer and others added 20 commits August 1, 2024 10:29
[REF] factor code
[UPD] fr translation and pot file
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
[REF] Don't use ``product.product`` model for Reasons, because Odoo remove
the fields ``expense_pdt`` ``and income_pdt`` from the model.
Use instead a new model ``pos.move.reason`` for this purpose.
[REF] Doesn't inherit from ``cash.box.in`` and ``cash.box.out`` model,
as there are bad designed and doesn't allow clean inheritance.
Instead, use new transient model ``wizard.pos.move.reason``.
[REF] Oca convention. add readme folder.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: pos-12.0/pos-12.0-pos_cash_move_reason
Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_cash_move_reason/
Currently translated at 100.0% (38 of 38 strings)

Translation: pos-12.0/pos-12.0-pos_cash_move_reason
Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_cash_move_reason/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: pos-12.0/pos-12.0-pos_cash_move_reason
Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_cash_move_reason/
Currently translated at 100.0% (38 of 38 strings)

Translation: pos-12.0/pos-12.0-pos_cash_move_reason
Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_cash_move_reason/fr_CH/
Currently translated at 7.9% (3 of 38 strings)

Translation: pos-12.0/pos-12.0-pos_cash_move_reason
Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_cash_move_reason/de/
@traitrantrobz traitrantrobz force-pushed the 17.0-mig-pos_cash_move_reason branch 3 times, most recently from 9951c4f to 3b916c8 Compare August 8, 2024 03:45
@traitrantrobz traitrantrobz reopened this Aug 27, 2024
@traitrantrobz traitrantrobz changed the title Draft [17.0][MIG] pos_cash_move_reason: Migration to 17.0 Aug 27, 2024
@traitrantrobz traitrantrobz marked this pull request as ready for review August 27, 2024 02:28
@FernandoRomera
Copy link

@traitrantrobz
Can you do rebase?

@traitrantrobz
Copy link
Author

@traitrantrobz Can you do rebase?
@FernandoRomera My update is the latest. What do you mean? My PR is waiting #1232 to be merged.

francesco-ooops and others added 13 commits September 23, 2024 11:43
Currently translated at 100.0% (38 of 38 strings)

Translation: pos-14.0/pos-14.0-pos_cash_move_reason
Translate-URL: https://translation.odoo-community.org/projects/pos-14-0/pos-14-0-pos_cash_move_reason/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: pos-15.0/pos-15.0-pos_cash_move_reason
Translate-URL: https://translation.odoo-community.org/projects/pos-15-0/pos-15-0-pos_cash_move_reason/
Currently translated at 100.0% (38 of 38 strings)

Translation: pos-15.0/pos-15.0-pos_cash_move_reason
Translate-URL: https://translation.odoo-community.org/projects/pos-15-0/pos-15-0-pos_cash_move_reason/it/
Currently translated at 100.0% (38 of 38 strings)

Translation: pos-15.0/pos-15.0-pos_cash_move_reason
Translate-URL: https://translation.odoo-community.org/projects/pos-15-0/pos-15-0-pos_cash_move_reason/it/
Currently translated at 100.0% (38 of 38 strings)

Translation: pos-15.0/pos-15.0-pos_cash_move_reason
Translate-URL: https://translation.odoo-community.org/projects/pos-15-0/pos-15-0-pos_cash_move_reason/it/
Currently translated at 97.3% (37 of 38 strings)

Translation: pos-15.0/pos-15.0-pos_cash_move_reason
Translate-URL: https://translation.odoo-community.org/projects/pos-15-0/pos-15-0-pos_cash_move_reason/ca/
Currently translated at 100.0% (38 of 38 strings)

Translation: pos-15.0/pos-15.0-pos_cash_move_reason
Translate-URL: https://translation.odoo-community.org/projects/pos-15-0/pos-15-0-pos_cash_move_reason/es/
@gurneyalex
Copy link
Member

@traitrantrobz the dependency has been merged. Can you update your PR removing the test-requirements.txt file (you just need to remove the commit that adds the file)

@traitrantrobz traitrantrobz force-pushed the 17.0-mig-pos_cash_move_reason branch from 57cdcdb to 6a44b78 Compare September 26, 2024 08:03
@FernandoRomera
Copy link

LGTM, test in runboat

@ivantodorovich
Copy link
Contributor

/ocabot migration pos_cash_move_reason

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Jan 7, 2025
@OCA-git-bot OCA-git-bot mentioned this pull request Jan 7, 2025
31 tasks
@ivantodorovich
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-1230-by-ivantodorovich-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jan 7, 2025
Signed-off-by ivantodorovich
@OCA-git-bot
Copy link
Contributor

@ivantodorovich The merge process could not be finalized, because command oca-gen-addon-readme --if-source-changed --org-name OCA --repo-name pos --branch 17.0 --addons-dir /tmp/tmpjdwtkv77 --commit failed with output:

/tmp/tmpjdwtkv77/pos_cash_move_reason/README.rst:92: (ERROR/3) Duplicate substitution definition name: "image1".
Traceback (most recent call last):
  File "/usr/local/bin/oca-gen-addon-readme", line 8, in <module>
    sys.exit(gen_addon_readme())
             ^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/click/core.py", line 1157, in __call__
    return self.main(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/click/core.py", line 1078, in main
    rv = self.invoke(ctx)
         ^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/click/core.py", line 1434, in invoke
    return ctx.invoke(self.callback, **ctx.params)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/click/core.py", line 783, in invoke
    return __callback(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/src/oca-maintainers-tools/tools/gen_addon_readme.py", line 575, in gen_addon_readme
    check_rst(readme_filename)
  File "/ocamt/src/oca-maintainers-tools/tools/gen_addon_readme.py", line 398, in check_rst
    publish_file(
  File "/ocamt/lib/python3.12/site-packages/docutils/core.py", line 422, in publish_file
    output, publisher = publish_programmatically(
                        ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/core.py", line 722, in publish_programmatically
    output = publisher.publish(enable_exit_status=enable_exit_status)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/core.py", line 234, in publish
    self.document = self.reader.read(self.source, self.parser,
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/readers/__init__.py", line 70, in read
    self.parse()
  File "/ocamt/lib/python3.12/site-packages/docutils/readers/__init__.py", line 76, in parse
    self.parser.parse(self.input, document)
  File "/ocamt/lib/python3.12/site-packages/docutils/parsers/rst/__init__.py", line 184, in parse
    self.statemachine.run(inputlines, document, inliner=self.inliner)
  File "/ocamt/lib/python3.12/site-packages/docutils/parsers/rst/states.py", line 169, in run
    results = StateMachineWS.run(self, input_lines, input_offset,
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/statemachine.py", line 233, in run
    context, next_state, result = self.check_line(
                                  ^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/statemachine.py", line 445, in check_line
    return method(match, context, next_state)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/parsers/rst/states.py", line 3034, in text
    self.section(title.lstrip(), source, style, lineno + 1, messages)
  File "/ocamt/lib/python3.12/site-packages/docutils/parsers/rst/states.py", line 325, in section
    self.new_subsection(title, lineno, messages)
  File "/ocamt/lib/python3.12/site-packages/docutils/parsers/rst/states.py", line 391, in new_subsection
    newabsoffset = self.nested_parse(
                   ^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/parsers/rst/states.py", line 279, in nested_parse
    state_machine.run(block, input_offset, memo=self.memo,
  File "/ocamt/lib/python3.12/site-packages/docutils/parsers/rst/states.py", line 195, in run
    results = StateMachineWS.run(self, input_lines, input_offset)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/statemachine.py", line 233, in run
    context, next_state, result = self.check_line(
                                  ^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/statemachine.py", line 445, in check_line
    return method(match, context, next_state)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/parsers/rst/states.py", line 2790, in underline
    self.section(title, source, style, lineno - 1, messages)
  File "/ocamt/lib/python3.12/site-packages/docutils/parsers/rst/states.py", line 325, in section
    self.new_subsection(title, lineno, messages)
  File "/ocamt/lib/python3.12/site-packages/docutils/parsers/rst/states.py", line 391, in new_subsection
    newabsoffset = self.nested_parse(
                   ^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/parsers/rst/states.py", line 279, in nested_parse
    state_machine.run(block, input_offset, memo=self.memo,
  File "/ocamt/lib/python3.12/site-packages/docutils/parsers/rst/states.py", line 195, in run
    results = StateMachineWS.run(self, input_lines, input_offset)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/statemachine.py", line 233, in run
    context, next_state, result = self.check_line(
                                  ^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/statemachine.py", line 445, in check_line
    return method(match, context, next_state)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/parsers/rst/states.py", line 2357, in explicit_markup
    nodelist, blank_finish = self.explicit_construct(match)
                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/parsers/rst/states.py", line 2369, in explicit_construct
    return method(self, expmatch)
           ^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/parsers/rst/states.py", line 2087, in substitution_def
    self.document.note_substitution_def(
  File "/ocamt/lib/python3.12/site-packages/docutils/nodes.py", line 1536, in note_substitution_def
    msg = self.reporter.error(
          ^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/utils/__init__.py", line 231, in error
    return self.system_message(self.ERROR_LEVEL, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/ocamt/lib/python3.12/site-packages/docutils/utils/__init__.py", line 197, in system_message
    raise SystemMessage(msg, level)
docutils.utils.SystemMessage: /tmp/tmpjdwtkv77/pos_cash_move_reason/README.rst:92: (ERROR/3) Duplicate substitution definition name: "image1".

@chaule97
Copy link

hola @ivantodorovich , could you merge in my PR #1283, I take over this PR

@ivantodorovich
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.