[15.0][FIX]sale_advance_payment: Amount residual with signed invoice amount #3542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@HaraldPanten @ValentinVinagre Could you review, please? |
ValentinVinagre
approved these changes
Jan 23, 2025
|
@ValentinVinagre I'm already in the contributors list. |
ah 😄 jajaja |
HaraldPanten
approved these changes
Jan 23, 2025
|
/ocabot merge patch |
|
On my way to merge this fine PR! |
|
@manuelregidor when it is merged please move it to the next versions. |
|
Congratulations, your PR was merged at eaf1a52. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this fix, field amount_residual in sale.order was calculated using the unsigned amounts of related invoices. That caused that amount_residual was wrongly calculated when a sale order had related customer credit notes.
T-7394