Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][FIX]sale_delivery_state: add state to silence warning #3555

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from

Conversation

PicchiSeba
Copy link

@PicchiSeba PicchiSeba commented Jan 30, 2025

Both sale_delivery_state and sale_stock add a delivery_status field. The two modules add the same selection options except for one, missing in sale_delivery_state. This is the "started" option.

With both modules installed we are witnessing a lot of warnings like the following

sale.order.delivery_status: selection=[('pending', 'Not Delivered'), ('started', 'Started'), ('partial', 'Partially Delivered'), ('full', 'Fully Delivered')] overrides existing selection; use selection_add instead 

With this PR we add the same option as sale_stock but we ignore it during the computation.

@PicchiSeba PicchiSeba marked this pull request as ready for review January 30, 2025 09:21
@PicchiSeba
Copy link
Author

question: given that both modules add the same field how do we ensure the execution of the right compute function when both of them are installed?

@PicchiSeba PicchiSeba force-pushed the 16.0-status-override-warning branch from 0519973 to 333f77a Compare February 4, 2025 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant