Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Allow manual configuration of incoming mail server #172

Closed
wants to merge 1 commit into from

Conversation

rven
Copy link

@rven rven commented Dec 1, 2023

When manual configuring an incoming mail server, the changes are not saved.

The problem is because the fields are marked as readonly by the server environment module.

With this change it is allowed to manually add an incoming mail server.

@len-foss
Copy link

What is the problem to be solved?

Improper configuration of email server in an environment is fairly risky, and so it is a feature that it would be impossible to change manually. Making this patch the default would mean losing the safety this brings. And changing something like that without big warnings would create problems for sure.

If the argument is that it is not a big problem if backup/restoration scripts make sure that there are no such risks, then why would this feature be needed?

My understanding would be that this change should be in another optional module if you really want it, but the default behaviour shouldn't change.

@rven
Copy link
Author

rven commented Dec 14, 2023

With this change it is possible to create manual entries in the mail configuration.

The mail servers defined in the configuration are still not updateable!

It's a bit strange to that you suggest to create an extra module to enable standard Odoo functionality again?

Outgoing mail servers can be entered manually!

BTW if you neutralize the DB it is done automatically by Odoo parts/odoo/addons/mail/data/neutralize.sql

@len-foss
Copy link

In that case, why bother with mail_environment at all? You can just uninstall the module and put mail environment changes into your backup/restore scripts, and then you can change everything manually.

@rven
Copy link
Author

rven commented Dec 14, 2023

We use them in combination.
The "test" environments are defined in the configuration to enable mailtrap by default.
But the customer should be able to change / add incoming mail servers manually in the production environment.
I don't see the problem why this change is breaking stuff! It just fixes a "bug" in this module.

@len-foss
Copy link

In that case it seems the need is covered by server_environment_data_encryption as is discussed in more details in issue 169.

@rven
Copy link
Author

rven commented Dec 14, 2023

Does this also allow to manually create an incoming mail server?
Because the values are not accepted at all, because the fields are readonly...

Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Apr 14, 2024
@github-actions github-actions bot closed this May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants