HDX-10241 Update VAT definitions to match Alembic migration scripts #71
+658
−596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re always indexed Add indexes to population|reference_period_start and poverty_rate|admin1_name - this is a reversion
Pull Request Test Coverage Report for Build 11435605920Details
💛 - Coveralls |
|
Thank you -- this sounds like a valuable change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparing Alembic migration scripts for the provider name change we noticed some inconsistencies in the primary key/index settings. This PR resolves those consistencies, or at least those that were apparent
One philosophical change is that we explicitly index the provider_admin1_name and provider_admin2_name columns. They typically belong to the primary key and are thus indexed, however the primary keys are composite and so search performance is not improved without explicitly indexing the column.