Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for missing "end verbatim" in doc #210

Closed
wants to merge 1 commit into from

Conversation

ddeclerck
Copy link
Contributor

There was a missing "end verbatim" in the file generated by cbrunt.tex.gen. Seems it's been like this for ages, but we only notice now because the MacOS CI began to fail for no apparent reason (in fact brew's texinfo version was updated from 7.1 to 7.2, which is probably the reason for this error to be detected).

@ddeclerck ddeclerck requested a review from GitMensch January 9, 2025 14:36
Copy link
Collaborator

@GitMensch GitMensch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comparing the versions from January 3rd and 9th:
the first has a text

@section Call environment
@verbatim

in Appendix I, the second an actual section in the PDF - so LGTM for upstream

just one requested change in the Changelog - but this can directly go upstream

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this is the first 2025 entry: please add 2025 to the copyright years found at the end of the file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, 2023 and 2024 are also missing though they have some ChangeLog entries. Should those be added too ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct, please adjust to 2009-2025

@ddeclerck
Copy link
Contributor Author

Merged in SVN @ 5418.

@GitMensch GitMensch closed this Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants